Enable flattening and unflattening of SkColorSpace

include/core/SkMatrix44.h

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkMatrix44_DEFINED
 #define SkMatrix44_DEFINED
 
@@ skipping 269 matching lines @@
     /** These methods allow one to efficiently read matrix entries into an
      *  array. The given array must have room for exactly 16 entries. Whenever
      *  possible, they will try to use memcpy rather than an entry-by-entry
      *  copy.
      */
     void asColMajorf(float[]) const;
     void asColMajord(double[]) const;
     void asRowMajorf(float[]) const;
     void asRowMajord(double[]) const;
 
+    /** Efficiently reads 12 matrix entries, ignoring the last col.
+     *  This is typically useful when we know the last col is (0, 0, 0, 1).
+     */
+    void as4x3ColMajorf(float[]) const;
+
     /** These methods allow one to efficiently set all matrix entries from an
      *  array. The given array must have room for exactly 16 entries. Whenever
      *  possible, they will try to use memcpy rather than an entry-by-entry
      *  copy.
      */
     void setColMajorf(const float[]);
     void setColMajord(const double[]);
     void setRowMajorf(const float[]);
     void setRowMajord(const double[]);
 
 #ifdef SK_MSCALAR_IS_FLOAT
     void setColMajor(const SkMScalar data[]) { this->setColMajorf(data); }
     void setRowMajor(const SkMScalar data[]) { this->setRowMajorf(data); }
 #else
     void setColMajor(const SkMScalar data[]) { this->setColMajord(data); }
     void setRowMajor(const SkMScalar data[]) { this->setRowMajord(data); }
 #endif
 
     /* This sets the top-left of the matrix and clears the translation and
      * perspective components (with [3][3] set to 1). */
     void set3x3(SkMScalar m00, SkMScalar m01, SkMScalar m02,
                 SkMScalar m10, SkMScalar m11, SkMScalar m12,
                 SkMScalar m20, SkMScalar m21, SkMScalar m22);
     void set3x3ColMajorf(const float[]);
 
+    /* This sets the top-left of the matrix and clears the
+     * perspective components (with [3][3] set to 1). */

[reed1, 2016/06/21 20:45:01]

Lets make these private helpers at first. Not sure this should be a public
helper yet.

[msarett, 2016/06/21 21:47:45]

sgtm, done.

+    void set4x3ColMajorf(const float[]);
+
     void setTranslate(SkMScalar dx, SkMScalar dy, SkMScalar dz);
     void preTranslate(SkMScalar dx, SkMScalar dy, SkMScalar dz);
     void postTranslate(SkMScalar dx, SkMScalar dy, SkMScalar dz);
 
     void setScale(SkMScalar sx, SkMScalar sy, SkMScalar sz);
     void preScale(SkMScalar sx, SkMScalar sy, SkMScalar sz);
     void postScale(SkMScalar sx, SkMScalar sy, SkMScalar sz);
 
     inline void setScale(SkMScalar scale) {
         this->setScale(scale, scale, scale);
@@ skipping 140 matching lines @@
     /**
      *  Does not take the time to 'compute' the typemask. Only returns true if
      *  we already know that this matrix is identity.
      */
     inline bool isTriviallyIdentity() const {
         return 0 == fTypeMask;
     }
 };
 
 #endif