Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2085633003: Send QUIC ping packets when there are draining streams, even if there are no open streams. (Closed)

Created:
4 years, 6 months ago by Ryan Hamilton
Modified:
4 years, 6 months ago
Reviewers:
Ian Swett
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Send QUIC ping packets when there are draining streams, even if there are no open streams. BUG=600001 Committed: https://crrev.com/03b32983a8ceb3a1da374cf34ce26b6085abd7b8 Cr-Commit-Position: refs/heads/master@{#400846}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M net/quic/quic_chromium_client_session.h View 1 chunk +1 line, -0 lines 1 comment Download
M net/quic/quic_chromium_client_session.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Ian Swett
lgtm https://codereview.chromium.org/2085633003/diff/1/net/quic/quic_chromium_client_session.h File net/quic/quic_chromium_client_session.h (right): https://codereview.chromium.org/2085633003/diff/1/net/quic/quic_chromium_client_session.h#newcode190 net/quic/quic_chromium_client_session.h:190: bool HasOpenDynamicStreams() const override; Maybe add a comment ...
4 years, 6 months ago (2016-06-20 22:51:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085633003/1
4 years, 6 months ago (2016-06-20 22:51:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 00:08:49 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 00:17:13 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/03b32983a8ceb3a1da374cf34ce26b6085abd7b8
Cr-Commit-Position: refs/heads/master@{#400846}

Powered by Google App Engine
This is Rietveld 408576698