media/base/audio_renderer_mixer.cc - Issue 2085603002: Fixing deadlock by removing unnesessary lock in AudioRendererMixer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/audio_renderer_mixer.cc

Issue 2085603002: Fixing deadlock by removing unnesessary lock in AudioRendererMixer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/base/audio_renderer_mixer.cc

diff --git a/media/base/audio_renderer_mixer.cc b/media/base/audio_renderer_mixer.cc

index 9959a78c8a9fe1760ee82fc09e2c4b9cd4aebb07..e4c1e8005cdf30220bf156de29b4148a1c35a0ac 100644

--- a/media/base/audio_renderer_mixer.cc

+++ b/media/base/audio_renderer_mixer.cc

@@ -115,7 +115,6 @@ void AudioRendererMixer::RemoveErrorCallback(const base::Closure& error_cb) {

OutputDeviceInfo AudioRendererMixer::GetOutputDeviceInfo() {

DVLOG(1) << __FUNCTION__;

- base::AutoLock auto_lock(lock_);

return audio_sink_->GetOutputDeviceInfo();

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »