Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2085573002: Reenable WebGL Image Chromium. (Closed)

Created:
4 years, 6 months ago by erikchen
Modified:
4 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Reland 1] Reenable WebGL Image Chromium. The feature was disabled because of two bugs. Both have since been fixed. BUG=617249, 581777 TBR=piman@chromium.org, kbr@chromium.org Committed: https://crrev.com/f5c146230498ed8e7c5b24d2361c0551415e368d Cr-Commit-Position: refs/heads/master@{#400709}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M content/child/runtime_features.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
erikchen
The WebGL conformance test failures should be fixed by: Do not use IOSurface copyTexImage2D workaround ...
4 years, 6 months ago (2016-06-20 16:32:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085573002/1
4 years, 6 months ago (2016-06-20 16:32:30 UTC) #5
piman
lgtm
4 years, 6 months ago (2016-06-20 16:40:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 17:29:23 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f5c146230498ed8e7c5b24d2361c0551415e368d Cr-Commit-Position: refs/heads/master@{#400709}
4 years, 6 months ago (2016-06-20 17:31:08 UTC) #9
erikchen
4 years, 6 months ago (2016-06-20 20:56:40 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2078333004/ by erikchen@chromium.org.

The reason for reverting is: Causes WebGL2 conformance test errors on some
devices.

https://bugs.chromium.org/p/chromium/issues/detail?id=620067.

Powered by Google App Engine
This is Rietveld 408576698