Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2650)

Issue 2085563002: Guard against missing element (issue 26685) (Closed)

Created:
4 years, 6 months ago by Brian Wilkerson
Modified:
4 years, 6 months ago
Reviewers:
scheglov, jwren
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/analysis_server/lib/src/services/completion/dart/optype.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
I don't know how to reproduce the behavior, but I'm fairly sure this will prevent ...
4 years, 6 months ago (2016-06-20 16:22:09 UTC) #2
scheglov
LGTM
4 years, 6 months ago (2016-06-20 16:23:27 UTC) #3
jwren
On 2016/06/20 16:23:27, scheglov wrote: > LGTM LGTM
4 years, 6 months ago (2016-06-20 16:25:03 UTC) #4
Brian Wilkerson
4 years, 6 months ago (2016-06-20 16:51:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1974dc5f208267c0615df6d670c6a2d01c2e2a6c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698