Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 2085553006: SOM: Removed alert-body div. (Closed)

Created:
4 years, 6 months ago by Tiff
Modified:
4 years, 6 months ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed the content too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M go/src/infra/appengine/sheriff-o-matic/elements/som-alert-item.html View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Tiff
PTAL
4 years, 6 months ago (2016-06-21 21:33:38 UTC) #2
seanmccullough1
https://codereview.chromium.org/2085553006/diff/1/go/src/infra/appengine/sheriff-o-matic/elements/som-alert-item.html File go/src/infra/appengine/sheriff-o-matic/elements/som-alert-item.html (right): https://codereview.chromium.org/2085553006/diff/1/go/src/infra/appengine/sheriff-o-matic/elements/som-alert-item.html#newcode78 go/src/infra/appengine/sheriff-o-matic/elements/som-alert-item.html:78: [[alert.body]] I think the intent was to remove alert.body ...
4 years, 6 months ago (2016-06-21 21:39:44 UTC) #4
Tiff
On 2016/06/21 at 21:39:44, seanmccullough wrote: > https://codereview.chromium.org/2085553006/diff/1/go/src/infra/appengine/sheriff-o-matic/elements/som-alert-item.html > File go/src/infra/appengine/sheriff-o-matic/elements/som-alert-item.html (right): > > https://codereview.chromium.org/2085553006/diff/1/go/src/infra/appengine/sheriff-o-matic/elements/som-alert-item.html#newcode78 ...
4 years, 6 months ago (2016-06-21 21:45:24 UTC) #5
seanmccullough1
lgtm
4 years, 6 months ago (2016-06-21 21:48:26 UTC) #6
seanmccullough
lgtm
4 years, 6 months ago (2016-06-21 21:48:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085553006/20001
4 years, 6 months ago (2016-06-21 21:53:11 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 22:26:15 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/7780e52fc82d28e95901002c2438f...

Powered by Google App Engine
This is Rietveld 408576698