Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: tools/gpu/gl/debug/DebugGLTestContext.cpp

Issue 2085553004: Don't track FB depth attachment in debug GL context (Closed) Base URL: https://skia.googlesource.com/skia.git@fix_testing
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gpu/gl/debug/GrFrameBufferObj.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gpu/gl/debug/DebugGLTestContext.cpp
diff --git a/tools/gpu/gl/debug/DebugGLTestContext.cpp b/tools/gpu/gl/debug/DebugGLTestContext.cpp
index 022d56a452a1ccd4c57260869a8759f14e358b7a..481abd547fb62ba9dbe3d9b3c9708eb077caaea1 100644
--- a/tools/gpu/gl/debug/DebugGLTestContext.cpp
+++ b/tools/gpu/gl/debug/DebugGLTestContext.cpp
@@ -263,10 +263,6 @@ public:
textures[i] == frameBuffer->getColor()->getID()) {
frameBuffer->setColor(nullptr);
}
- if (frameBuffer->getDepth() &&
- textures[i] == frameBuffer->getDepth()->getID()) {
- frameBuffer->setDepth(nullptr);
- }
if (frameBuffer->getStencil() &&
textures[i] == frameBuffer->getStencil()->getID()) {
frameBuffer->setStencil(nullptr);
@@ -342,10 +338,6 @@ public:
renderBuffers[i] == frameBuffer->getColor()->getID()) {
frameBuffer->setColor(nullptr);
}
- if (frameBuffer->getDepth() &&
- renderBuffers[i] == frameBuffer->getDepth()->getID()) {
- frameBuffer->setDepth(nullptr);
- }
if (frameBuffer->getStencil() &&
renderBuffers[i] == frameBuffer->getStencil()->getID()) {
frameBuffer->setStencil(nullptr);
@@ -397,9 +389,6 @@ public:
case GR_GL_COLOR_ATTACHMENT0:
framebuffer->setColor(renderbuffer);
break;
- case GR_GL_DEPTH_ATTACHMENT:
- framebuffer->setDepth(renderbuffer);
- break;
case GR_GL_STENCIL_ATTACHMENT:
framebuffer->setStencil(renderbuffer);
break;
@@ -438,9 +427,6 @@ public:
case GR_GL_COLOR_ATTACHMENT0:
framebuffer->setColor(texture);
break;
- case GR_GL_DEPTH_ATTACHMENT:
- framebuffer->setDepth(texture);
- break;
case GR_GL_STENCIL_ATTACHMENT:
framebuffer->setStencil(texture);
break;
« no previous file with comments | « no previous file | tools/gpu/gl/debug/GrFrameBufferObj.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698