Issue 2085553002: Implement _SameResolutionValidator as AstComparator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2085553002: Implement _SameResolutionValidator as AstComparator. (Closed)

Created:
4 years, 6 months ago by scheglov

Modified:
4 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Implement _SameResolutionValidator as AstComparator. This required couple tweaks in AstComparator to make it possible to override failing and comparision. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/e2afc0161bebce91a873634a9d964a04904c7e92

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+122 lines, -849 lines)			Patch
M	pkg/analyzer/lib/src/dart/ast/utilities.dart	View	5 chunks	+50 lines, -12 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart	View	5 chunks	+67 lines, -835 lines	0 comments	Download
M	pkg/analyzer/test/generated/incremental_resolver_test.dart	View	1 chunk	+5 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

4 years, 6 months ago (2016-06-20 16:17:34 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e2afc0161bebce91a873634a9d964a04904c7e92 (presubmit successful).