Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 208553004: ozone: dri: Do initial cursor set (Closed)

Created:
6 years, 9 months ago by spang
Modified:
6 years, 8 months ago
Reviewers:
rjkroege, dnicoara
CC:
chromium-reviews, rjkroege, kalyank, ozone-reviews_chromium.org
Visibility:
Public.

Description

ozone: dri: Do initial cursor set The cursor is invisible unless set explicitly, so set a bitmap from CursorFactoryEvdevDri upon construction. Configuration of the cursor plane must be delayed until we've configured the hardware, so store the bitmap on DriSurfaceFactory and set it in RealizeAcceleratedWidget. TEST=content_shell --ozone-platform=dri BUG=252315 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260189

Patch Set 1 #

Total comments: 2

Patch Set 2 : revert front/back changes #

Patch Set 3 : move cursor swap buffers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -11 lines) Patch
M ui/gfx/ozone/dri/dri_surface_factory.h View 3 chunks +7 lines, -0 lines 0 comments Download
M ui/gfx/ozone/dri/dri_surface_factory.cc View 1 2 4 chunks +27 lines, -5 lines 0 comments Download
M ui/gfx/ozone/dri/hardware_display_controller.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/ozone/dri/hardware_display_controller.cc View 1 2 1 chunk +7 lines, -5 lines 0 comments Download
M ui/ozone/platform/dri/cursor_factory_evdev_dri.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
spang
6 years, 9 months ago (2014-03-21 19:11:37 UTC) #1
dnicoara
https://codereview.chromium.org/208553004/diff/1/ui/gfx/ozone/dri/dri_surface_factory.cc File ui/gfx/ozone/dri/dri_surface_factory.cc (right): https://codereview.chromium.org/208553004/diff/1/ui/gfx/ozone/dri/dri_surface_factory.cc#newcode381 ui/gfx/ozone/dri/dri_surface_factory.cc:381: cursor_surface_->SwapBuffers(); Could we move this inside HardwareDisplayController::SetCursor? My bad ...
6 years, 9 months ago (2014-03-21 21:38:35 UTC) #2
spang
https://codereview.chromium.org/208553004/diff/1/ui/gfx/ozone/dri/dri_surface_factory.cc File ui/gfx/ozone/dri/dri_surface_factory.cc (right): https://codereview.chromium.org/208553004/diff/1/ui/gfx/ozone/dri/dri_surface_factory.cc#newcode381 ui/gfx/ozone/dri/dri_surface_factory.cc:381: cursor_surface_->SwapBuffers(); On 2014/03/21 21:38:35, dnicoara wrote: > Could we ...
6 years, 9 months ago (2014-03-26 22:26:35 UTC) #3
dnicoara
lgtm
6 years, 9 months ago (2014-03-27 01:46:18 UTC) #4
rjkroege
6 years, 9 months ago (2014-03-27 17:55:44 UTC) #5
rjkroege
lgtm
6 years, 9 months ago (2014-03-27 17:55:45 UTC) #6
spang
The CQ bit was checked by spang@chromium.org
6 years, 9 months ago (2014-03-27 18:23:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/208553004/40001
6 years, 9 months ago (2014-03-27 18:24:44 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 21:10:28 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=289643
6 years, 9 months ago (2014-03-27 21:10:29 UTC) #10
spang
The CQ bit was checked by spang@chromium.org
6 years, 8 months ago (2014-03-28 16:02:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/208553004/40001
6 years, 8 months ago (2014-03-28 16:06:18 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-03-28 17:45:29 UTC) #13
Message was sent while issue was closed.
Change committed as 260189

Powered by Google App Engine
This is Rietveld 408576698