Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2085523003: Add autocomplete values for CSS contain (Closed)

Created:
4 years, 6 months ago by einbinder
Modified:
4 years, 5 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Add autocomplete values for CSS contain BUG=619844 Committed: https://crrev.com/ae37548c093fd06e2c99e9ddcb3b18e36759b07d Cr-Commit-Position: refs/heads/master@{#402270}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
einbinder
Hi
4 years, 6 months ago (2016-06-20 16:52:53 UTC) #3
dgozman
lgtm
4 years, 6 months ago (2016-06-20 16:57:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2085523003/1
4 years, 5 months ago (2016-06-27 18:53:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 20:26:24 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ae37548c093fd06e2c99e9ddcb3b18e36759b07d Cr-Commit-Position: refs/heads/master@{#402270}
4 years, 5 months ago (2016-06-27 20:29:07 UTC) #9
einbinder
4 years, 5 months ago (2016-06-28 00:01:49 UTC) #10
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2101083002/ by einbinder@chromium.org.

The reason for reverting is:
https://chromium.googlesource.com/chromium/src/+/f2168263f19ab4f81c56d6258db7...
already fixes this.

Powered by Google App Engine
This is Rietveld 408576698