[Findit] Show the list of failed build cycles that a culprit is responsible for.

[Findit] Show the list of failed build cycles that a culprit is responsible for.

BUG=621140
Committed: https://chromium.googlesource.com/infra/infra/+/5104e1ec834027da7db8c5eba2f8de2a97fb0422

[stgao, 2016-06-21 15:15:40]

stgao@chromium.org changed reviewers:
+ chanli@chromium.org, lijeffrey@chromium.org

[stgao, 2016-06-21 15:15:40]

ptal

This is the last CL to enable posting to code-review.

[lijeffrey, 2016-06-21 18:03:51]

lgtm

[chanli, 2016-06-21 21:43:56]

lgtm with one suggestion.

https://codereview.chromium.org/2085513003/diff/1/appengine/findit/templates/...
File appengine/findit/templates/waterfall/culprit.html (right):

https://codereview.chromium.org/2085513003/diff/1/appengine/findit/templates/...
appengine/findit/templates/waterfall/culprit.html:18: <h1>Builds</h1>
Just an idea, no need to implement in this CL: do you want to consolidate
consecutive builds in one row?

[stgao, 2016-06-24 17:24:38]

Added unittests.

https://codereview.chromium.org/2085513003/diff/1/appengine/findit/templates/...
File appengine/findit/templates/waterfall/culprit.html (right):

https://codereview.chromium.org/2085513003/diff/1/appengine/findit/templates/...
appengine/findit/templates/waterfall/culprit.html:18: <h1>Builds</h1>
On 2016/06/21 21:43:56, chanli wrote:
> Just an idea, no need to implement in this CL: do you want to consolidate
> consecutive builds in one row?

I guess not. This page is to give the CL owner a list of representative build
failures, and duplicate ones from the same builder seems not helpful.

[chanli, 2016-06-24 21:35:20]

On 2016/06/24 17:24:38, stgao wrote:
> Added unittests.
> 
>
https://codereview.chromium.org/2085513003/diff/1/appengine/findit/templates/...
> File appengine/findit/templates/waterfall/culprit.html (right):
> 
>
https://codereview.chromium.org/2085513003/diff/1/appengine/findit/templates/...
> appengine/findit/templates/waterfall/culprit.html:18: <h1>Builds</h1>
> On 2016/06/21 21:43:56, chanli wrote:
> > Just an idea, no need to implement in this CL: do you want to consolidate
> > consecutive builds in one row?
> 
> I guess not. This page is to give the CL owner a list of representative build
> failures, and duplicate ones from the same builder seems not helpful.

lgtm

[stgao, 2016-06-28 16:27:41]

The CQ bit was checked by stgao@chromium.org

[stgao, 2016-06-28 16:27:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
lijeffrey@chromium.org
Link to the patchset: https://codereview.chromium.org/2085513003/#ps20001
(title: "Add unittests.")

[commit-bot: I haz the power, 2016-06-28 16:27:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 16:51:54]

Description was changed from

==========
[Findit] Show the list of failed build cycles that a culprit is responsible for.

BUG=621140
==========

to

==========
[Findit] Show the list of failed build cycles that a culprit is responsible for.

BUG=621140

Committed:
https://chromium.googlesource.com/infra/infra/+/5104e1ec834027da7db8c5eba2f8d...
==========

[commit-bot: I haz the power, 2016-06-28 16:51:55]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/5104e1ec834027da7db8c5eba2f8d...