Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 2085493002: Fixup LoadImageInfo type checking. (Closed)

Created:
4 years, 6 months ago by dsinclair
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang, Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fixup LoadImageInfo type checking. The ::DetectImageType method does more then just detecting the image type, it also sets up various needed structures to handle the decoding. Instead of skipping the ::DetectImageType call this CL changes the code to return early if the image check fails. This should allow us to stop working on images which do not match the required data format. BUG=chromium:621094 Committed: https://pdfium.googlesource.com/pdfium/+/54d027dbbff8a0270531855082e4f61cb457c173

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M core/fxcodec/codec/fx_codec_progress.cpp View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dsinclair
PTAL.
4 years, 6 months ago (2016-06-20 13:50:54 UTC) #2
Lei Zhang
lgtm
4 years, 6 months ago (2016-06-20 16:03:32 UTC) #3
Oliver Chang
lgtm
4 years, 6 months ago (2016-06-20 16:05:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085493002/1
4 years, 6 months ago (2016-06-20 16:09:42 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 16:10:02 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/54d027dbbff8a0270531855082e4f61cb457...

Powered by Google App Engine
This is Rietveld 408576698