Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2085483003: Flip Mac CQ bots and matching waterfall bots to GN. (Closed)

Created:
4 years, 6 months ago by Robert Sesek
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flip Mac CQ bots and matching waterfall bots to GN. This affects: tryserver.chromium.mac: - mac_chromium_compile_dbg_ng - mac_chromium_compile_rel_ng - mac_chromium_dbg_ng - mac_chromium_rel_ng chromium.mac: - Mac Builder - Mac Builder (dbg) chromium.gpu: - GPU Mac Builder - GPU Mac Builder (dbg) chromium.gpu.fyi - GPU Mac Builder - GPU Mac Builder (dbg) patch from issue 2046863005 at patchset 60001 (http://crrev.com/2046863005#ps60001) R=dpranke@chromium.org BUG=618468 Committed: https://crrev.com/04817566fb446d8315cbc4049266c4859a010a74 Cr-Commit-Position: refs/heads/master@{#400895}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M tools/mb/mb_config.pyl View 5 chunks +8 lines, -16 lines 0 comments Download
M tools/perf/chrome_telemetry_build/BUILD.gn View 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Robert Sesek
It's green!
4 years, 6 months ago (2016-06-21 02:43:57 UTC) #1
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-21 03:52:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085483003/1
4 years, 6 months ago (2016-06-21 03:52:37 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 04:49:29 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/04817566fb446d8315cbc4049266c4859a010a74 Cr-Commit-Position: refs/heads/master@{#400895}
4 years, 6 months ago (2016-06-21 04:56:52 UTC) #7
Dirk Pranke
On 2016/06/21 04:56:52, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 6 months ago (2016-06-21 16:41:33 UTC) #8
Robert Sesek
4 years, 6 months ago (2016-06-21 16:44:07 UTC) #9
Message was sent while issue was closed.
On 2016/06/21 16:41:33, Dirk Pranke wrote:
> Fixing in a separate CL.

Thanks!

Powered by Google App Engine
This is Rietveld 408576698