Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2085463002: [iOS/GN] Add a variable to configure the depth of "bundle_pool". (Closed)

Created:
4 years, 6 months ago by sdefresne
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS/GN] Add a variable to configure the depth of "bundle_pool". Chrome on iOS downstream developer wants to be able to control the size of the "bundle_pool" independently of the number of concurrent link targets. BUG=612786 Committed: https://crrev.com/f42145ad884229d1bd0f1b9012d5afeedb180f68 Cr-Commit-Position: refs/heads/master@{#402166}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M build/toolchain/mac/BUILD.gn View 1 2 3 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
sdefresne
Please take a look.
4 years, 6 months ago (2016-06-20 12:50:10 UTC) #2
justincohen
lgtm, thanks!
4 years, 6 months ago (2016-06-20 12:50:47 UTC) #3
Dirk Pranke
What do you need to change the value to? Can we just adjust the default ...
4 years, 6 months ago (2016-06-20 16:32:32 UTC) #4
justincohen
sdefresne@ and I discussed using 64.
4 years, 6 months ago (2016-06-21 07:25:52 UTC) #5
sdefresne
On 2016/06/21 07:25:52, justincohen wrote: > sdefresne@ and I discussed using 64. The default is ...
4 years, 6 months ago (2016-06-21 07:35:28 UTC) #6
Dirk Pranke
okay. It'd be nice if we can figure out a way to be smarter here, ...
4 years, 6 months ago (2016-06-21 23:45:51 UTC) #7
sdefresne
On 2016/06/21 23:45:51, Dirk Pranke wrote: > okay. It'd be nice if we can figure ...
4 years, 6 months ago (2016-06-22 07:30:29 UTC) #8
Dirk Pranke
Oh, sorry, I thought I had approved this already. lgtm.
4 years, 6 months ago (2016-06-22 15:14:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2085463002/60001
4 years, 5 months ago (2016-06-27 12:58:45 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-06-27 14:05:42 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 14:07:35 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f42145ad884229d1bd0f1b9012d5afeedb180f68
Cr-Commit-Position: refs/heads/master@{#402166}

Powered by Google App Engine
This is Rietveld 408576698