Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2085413002: gles2_conform: Fix sources list in GN/gypi. (Closed)

Created:
4 years, 6 months ago by Jamie Madill
Modified:
4 years, 6 months ago
Reviewers:
brettw, piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gles2_conform: Fix sources list in GN/gypi. The sources list in the gypi included other lists of sources, which the GN files don't know how to parse recursively. BUG=622108 R=piman@chromium.org,brettw@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/0096cb016cc6bfd8cf1a0cd51501504ba547bfff Cr-Commit-Position: refs/heads/master@{#401415}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M gpu/gles2_conform_support/gles2_conform.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/gles2_conform_support/gles2_conform_test.gyp View 3 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Jamie Madill
PTAL
4 years, 6 months ago (2016-06-22 20:24:13 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085413002/1
4 years, 6 months ago (2016-06-22 20:24:50 UTC) #6
brettw
lgtm
4 years, 6 months ago (2016-06-22 20:42:57 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-22 21:19:54 UTC) #9
piman
lgtm
4 years, 6 months ago (2016-06-22 21:27:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085413002/1
4 years, 6 months ago (2016-06-22 21:36:02 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 21:42:42 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 21:44:46 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0096cb016cc6bfd8cf1a0cd51501504ba547bfff
Cr-Commit-Position: refs/heads/master@{#401415}

Powered by Google App Engine
This is Rietveld 408576698