Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1378)

Issue 2085393002: Add ability to query desktop process for its session ID by the network process (Closed)

Created:
4 years, 6 months ago by joedow
Modified:
4 years, 6 months ago
Reviewers:
*Sergey Ulanov, Hzj_jie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ability to query desktop process for its session ID by the network process This change adds an access right to the Chromoting desktop process on Windows which allows the network process (running as Local Service) to query its session ID using its PID. This is the first change needed to allow the network service to restrict access to global resources to the Windows session being remoted. BUG=591746 Committed: https://crrev.com/4cfe59be5d49919425d676ce63c5d46b40316b64 Cr-Commit-Position: refs/heads/master@{#401738}

Patch Set 1 #

Patch Set 2 : Cleaning up initial review #

Patch Set 3 : More cleanup #

Patch Set 4 : Fixing the default DACL for the Desktop Process #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -7 lines) Patch
M remoting/host/desktop_session_win.cc View 1 2 3 2 chunks +18 lines, -1 line 0 comments Download
M remoting/host/win/wts_session_process_delegate.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M remoting/host/win/wts_session_process_delegate.cc View 1 2 6 chunks +29 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
joedow
This is the first of several changes needed to use the Windows Session ID to ...
4 years, 6 months ago (2016-06-22 23:16:00 UTC) #3
Hzj_jie
lgtm
4 years, 6 months ago (2016-06-23 00:08:47 UTC) #4
joedow
I realized that I needed to add the default DACLs for SYSTEM and the BA ...
4 years, 6 months ago (2016-06-23 00:12:54 UTC) #5
joedow
Ping!
4 years, 6 months ago (2016-06-23 21:13:43 UTC) #6
Sergey Ulanov
lgtm
4 years, 6 months ago (2016-06-23 21:29:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085393002/60001
4 years, 6 months ago (2016-06-23 21:53:27 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-23 21:59:11 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 22:01:01 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4cfe59be5d49919425d676ce63c5d46b40316b64
Cr-Commit-Position: refs/heads/master@{#401738}

Powered by Google App Engine
This is Rietveld 408576698