[Cronet] Fix UploadTest#testUploadChannelWithReadError

components/cronet/android/test/javatests/src/org/chromium/net/UploadTest.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net;
 
 import android.test.suitebuilder.annotation.SmallTest;
 
 import org.chromium.base.test.util.Feature;
 
@@ skipping 192 matching lines @@
     @Feature({"Cronet"})
     public void testUploadChannelWithReadError() throws Exception {
         TestHttpUrlRequestListener listener = new TestHttpUrlRequestListener();
         HttpUrlRequest request = createRequest(
                 NativeTestServer.getEchoBodyURL(), listener);
         setUploadChannel(request, "text/plain", UPLOAD_CHANNEL_DATA,
                          UPLOAD_CHANNEL_DATA.length() + 2);
         request.start();
         listener.blockForComplete();
 
-        assertEquals(200, listener.mHttpStatusCode);
+        assertEquals(0, listener.mHttpStatusCode);
         assertEquals(UPLOAD_CHANNEL_DATA + "\0\0", listener.mResponseAsString);

[mmenke, 2016/06/23 21:47:07]

Is this second check still true?

[xunjieli, 2016/06/23 21:49:13]

I am not sure. Still running test. Will update once the test result is out.

[xunjieli, 2016/06/23 22:13:07]

Done. It is null. We aren't able to assert on the net error code (which is
ERR_FAILED in this case) because this is the legacy API (which doesn't expose
net error code)

     }
 
     /**
      * Tests Content-Type can be set when uploading from a channel.
      */
     @SmallTest
     @Feature({"Cronet"})
     public void testUploadChannelContentType() throws Exception {
         String contentTypes[] = {"text/plain", "chicken/spicy"};
         for (String contentType : contentTypes) {
@@ skipping 114 matching lines @@
         // Upload a single empty chunk.
         ByteBuffer byteBuffer = ByteBuffer.allocateDirect(0);
         request.appendChunk(byteBuffer, true);
 
         listener.blockForComplete();
 
         assertEquals(200, listener.mHttpStatusCode);
         assertEquals("", listener.mResponseAsString);
     }
 }