remoting/host/security_key/gnubby_extension.cc - Issue 2085353004: Update GnubbyAuthHandler to use the current session ID

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/security_key/gnubby_extension.cc

Issue 2085353004: Update GnubbyAuthHandler to use the current session ID (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@host_extension

Patch Set: Updating a comment Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « remoting/host/security_key/gnubby_auth_handler_win_unittest.cc ('k') | remoting/host/security_key/gnubby_extension_session.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/host/security_key/gnubby_extension.cc

diff --git a/remoting/host/security_key/gnubby_extension.cc b/remoting/host/security_key/gnubby_extension.cc

index 469baa1c60239e83334fa6195a209c40f8dddd9f..885ed3045d4f24b52c67547dbde152b305d0627e 100644

--- a/remoting/host/security_key/gnubby_extension.cc

+++ b/remoting/host/security_key/gnubby_extension.cc

@@ -24,13 +24,12 @@ std::string GnubbyExtension::capability() const {

}

std::unique_ptr<HostExtensionSession> GnubbyExtension::CreateExtensionSession(

- ClientSessionDetails* client_session_details,

+ ClientSessionDetails* details,

protocol::ClientStub* client_stub) {

// TODO(joedow): Update this mechanism to allow for multiple sessions. The

// extension will only send messages through the initial

- // |client_stub| with the current design.

- // TODO(joedow): Update GnubbyExtensionSession for |client_session_details|.

- return base::WrapUnique(new GnubbyExtensionSession(client_stub));

+ // |client_stub| and |details| with the current design.

+ return base::WrapUnique(new GnubbyExtensionSession(details, client_stub));

}

} // namespace remoting