Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: remoting/host/security_key/gnubby_auth_handler.h

Issue 2085353004: Update GnubbyAuthHandler to use the current session ID (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@host_extension
Patch Set: Fixing a build break Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/security_key/gnubby_auth_handler.h
diff --git a/remoting/host/security_key/gnubby_auth_handler.h b/remoting/host/security_key/gnubby_auth_handler.h
index 0a6a7551300d7787ca47752bda4b7a1cf9a57d09..0711a7cbc3b197a34c599bb165a3cc328cbe7325 100644
--- a/remoting/host/security_key/gnubby_auth_handler.h
+++ b/remoting/host/security_key/gnubby_auth_handler.h
@@ -17,6 +17,8 @@ class FilePath;
namespace remoting {
+class ClientSessionDetails;
+
// Class responsible for proxying authentication data between a local gnubbyd
// and the client.
class GnubbyAuthHandler {
@@ -28,11 +30,12 @@ class GnubbyAuthHandler {
SendMessageCallback;
// Creates a platform-specific GnubbyAuthHandler.
- // All invocations of |callback| are guaranteed to occur before the underlying
- // GnubbyAuthHandler object is destroyed. It is not safe to destroy the
- // GnubbyAuthHandler object within the callback.
+ // All invocations of the callbacks are guaranteed to occur before the
Sergey Ulanov 2016/06/29 22:36:46 rephrase this, now that there is only one callback
joedow 2016/06/30 00:10:08 Done.
+ // underlying GnubbyAuthHandler object is destroyed. It is not safe to
+ // destroy the GnubbyAuthHandler object within the callback.
static std::unique_ptr<GnubbyAuthHandler> Create(
- const SendMessageCallback& callback);
+ ClientSessionDetails* client_session_details,
+ const SendMessageCallback& send_message_callback);
#if defined(OS_LINUX)
// Specify the name of the socket to listen to gnubby requests on.

Powered by Google App Engine
This is Rietveld 408576698