Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: remoting/host/security_key/gnubby_extension_session.h

Issue 2085353004: Update GnubbyAuthHandler to use the current session ID (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@host_extension
Patch Set: Fixing a non-windows build break and some additional cleanup Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/security_key/gnubby_extension_session.h
diff --git a/remoting/host/security_key/gnubby_extension_session.h b/remoting/host/security_key/gnubby_extension_session.h
index 65319437616e2175cb04dcb409b4126304bd3cc5..1625b9d9b7bd52f50c0d16d65a891391e3a002cf 100644
--- a/remoting/host/security_key/gnubby_extension_session.h
+++ b/remoting/host/security_key/gnubby_extension_session.h
@@ -5,6 +5,7 @@
#ifndef REMOTING_HOST_SECURITY_KEY_GNUBBY_EXTENSION_SESSION_H_
#define REMOTING_HOST_SECURITY_KEY_GNUBBY_EXTENSION_SESSION_H_
+#include <cstdint>
#include <memory>
#include <string>
@@ -19,6 +20,7 @@ class DictionaryValue;
namespace remoting {
+class ClientSessionDetails;
class GnubbyAuthHandler;
namespace protocol {
@@ -28,7 +30,8 @@ class ClientStub;
// A HostExtensionSession implementation that enables Security Key support.
class GnubbyExtensionSession : public HostExtensionSession {
public:
- explicit GnubbyExtensionSession(protocol::ClientStub* client_stub);
+ GnubbyExtensionSession(ClientSessionDetails* client_session_details,
+ protocol::ClientStub* client_stub);
~GnubbyExtensionSession() override;
// HostExtensionSession interface.
@@ -48,12 +51,17 @@ class GnubbyExtensionSession : public HostExtensionSession {
void SendMessageToClient(int connection_id, const std::string& data) const;
+ uint32_t GetDesktopSessionId() const;
+
// Ensures GnubbyExtensionSession methods are called on the same thread.
base::ThreadChecker thread_checker_;
// Interface through which messages can be sent to the client.
protocol::ClientStub* client_stub_ = nullptr;
+ // Interface which provides details about the client session.
+ ClientSessionDetails* client_session_details_ = nullptr;
+
// Handles platform specific gnubby operations.
std::unique_ptr<GnubbyAuthHandler> gnubby_auth_handler_;

Powered by Google App Engine
This is Rietveld 408576698