Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Unified Diff: remoting/host/security_key/gnubby_auth_handler_linux.cc

Issue 2085353004: Update GnubbyAuthHandler to use the current session ID (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@host_extension
Patch Set: Fixing a non-windows build break and some additional cleanup Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/security_key/gnubby_auth_handler_linux.cc
diff --git a/remoting/host/security_key/gnubby_auth_handler_linux.cc b/remoting/host/security_key/gnubby_auth_handler_linux.cc
index 5ba1ee2db4f11f9d011b8ec645620a42816b2a26..f84b0d330a54fde057a43a2ede78ffdec8059646 100644
--- a/remoting/host/security_key/gnubby_auth_handler_linux.cc
+++ b/remoting/host/security_key/gnubby_auth_handler_linux.cc
@@ -66,6 +66,7 @@ class GnubbyAuthHandlerLinux : public GnubbyAuthHandler {
const std::string& response) override;
void SendErrorAndCloseConnection(int gnubby_connection_id) override;
void SetSendMessageCallback(const SendMessageCallback& callback) override;
+ void SetSessionIdCallback(const SessionIdCallback& callback) override;
size_t GetActiveConnectionCountForTest() const override;
void SetRequestTimeoutForTest(base::TimeDelta timeout) override;
@@ -113,9 +114,10 @@ class GnubbyAuthHandlerLinux : public GnubbyAuthHandler {
};
std::unique_ptr<GnubbyAuthHandler> GnubbyAuthHandler::Create(
- const SendMessageCallback& callback) {
+ const SendMessageCallback& send_message_callback,
+ const SessionIdCallback& session_id_callback) {
std::unique_ptr<GnubbyAuthHandler> auth_handler(new GnubbyAuthHandlerLinux());
- auth_handler->SetSendMessageCallback(callback);
+ auth_handler->SetSendMessageCallback(send_message_callback);
return auth_handler;
}
@@ -199,6 +201,12 @@ void GnubbyAuthHandlerLinux::SetSendMessageCallback(
send_message_callback_ = callback;
}
+void GnubbyAuthHandlerLinux::SetSessionIdCallback(
+ const SessionIdCallback& callback) {
+ // SessionIdCallback is not currently used for this platform.
+ NOTREACHED();
+}
+
size_t GnubbyAuthHandlerLinux::GetActiveConnectionCountForTest() const {
return active_sockets_.size();
}

Powered by Google App Engine
This is Rietveld 408576698