Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2085333002: add a Chrome builder to the CQ (Closed)

Created:
4 years, 6 months ago by mtklein_C
Modified:
4 years, 6 months ago
Reviewers:
rmistry, mtklein, reed1
CC:
reviews_skia.org, borenet
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add a Chrome builder to the CQ This appears to be the fastest Chrome builder, averaging 8-9 minutes. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085333002 Committed: https://skia.googlesource.com/skia/+/cb4efa90ab5f6ea7cf5e0f44aec6f4e6418aad3d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M infra/branch-config/cq.cfg View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085333002/1
4 years, 6 months ago (2016-06-22 15:35:44 UTC) #3
mtklein_C
Am I doing this right? Are we surprised the CQ dry run did not pick ...
4 years, 6 months ago (2016-06-22 15:37:11 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-22 15:52:14 UTC) #7
rmistry
+Eric for FYI. This looks right, we will have to watch it after it lands ...
4 years, 6 months ago (2016-06-22 17:13:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085333002/1
4 years, 6 months ago (2016-06-22 17:22:01 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/cb4efa90ab5f6ea7cf5e0f44aec6f4e6418aad3d
4 years, 6 months ago (2016-06-22 17:22:59 UTC) #12
rmistry
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2087913003/ by rmistry@google.com. ...
4 years, 6 months ago (2016-06-22 17:40:46 UTC) #13
rmistry
4 years, 6 months ago (2016-06-22 18:36:53 UTC) #14
Message was sent while issue was closed.
On 2016/06/22 17:40:46, rmistry wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/2087913003/ by mailto:rmistry@google.com.
> 
> The reason for reverting is: Reverting due to purple trybots in
> https://codereview.chromium.org/2087343002/
> 
> We will have to investigate...

Turns out this CL was not the cause of the purple. I'll resubmit it tomorrow
morning.

Powered by Google App Engine
This is Rietveld 408576698