Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: pydir/build-runtime.py

Issue 2085303002: Subzero, MIPS32: Cross-testing enabled for MIPS32 (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Changes according to review comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Makefile.standalone ('k') | pydir/crosstest.py » ('j') | pydir/crosstest.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pydir/build-runtime.py
diff --git a/pydir/build-runtime.py b/pydir/build-runtime.py
index caed29722f285d69ea552ac3d1f414aad864e5c8..d22dc87532c6412f60264244280db6bc353bb3c9 100755
--- a/pydir/build-runtime.py
+++ b/pydir/build-runtime.py
@@ -9,7 +9,7 @@ import targets
from utils import FindBaseNaCl, GetObjcopyCmd, shellcmd
-def Translate(ll_files, extra_args, obj, verbose):
+def Translate(ll_files, extra_args, obj, verbose, target):
"""Translate a set of input bitcode files into a single object file.
Use pnacl-llc to translate textual bitcode input ll_files into object file
@@ -17,7 +17,6 @@ def Translate(ll_files, extra_args, obj, verbose):
"""
shellcmd(['cat'] + ll_files + ['|',
'pnacl-llc',
- '-externalize',
Jim Stichnoth 2016/09/06 19:04:44 Why is -externalize removed? This actually breaks
'-function-sections',
'-O2',
'-filetype=obj',
@@ -25,7 +24,7 @@ def Translate(ll_files, extra_args, obj, verbose):
'-arm-enable-dwarf-eh=1',
'-o', obj
] + extra_args, echo=verbose)
- shellcmd([GetObjcopyCmd(),
+ shellcmd([GetObjcopyCmd(target),
'--strip-symbol=nacl_tp_tdb_offset',
'--strip-symbol=nacl_tp_tls_offset',
obj
@@ -56,7 +55,7 @@ def MakeRuntimesForTarget(target_info, ll_files,
Translate(ll_files,
['-mtriple=' + target_info.triple] + target_info.llc_flags,
TmpFile('{dir}/szrt_native_{target}.tmp.o'),
- verbose)
+ verbose,target_info.target)
# Compile srcdir/szrt_profiler.c to
# tempdir/szrt_profiler_native_{target}.o.
shellcmd(['clang',
@@ -81,7 +80,7 @@ def MakeRuntimesForTarget(target_info, ll_files,
['-m {ld_emu}'.format(ld_emu=target_info.ld_emu)],
OutFile('{rtdir}/szrt_native_{target}.o'),
verbose)
- shellcmd([GetObjcopyCmd(),
+ shellcmd([GetObjcopyCmd(target_info.target),
'--strip-symbol=NATIVE',
OutFile('{rtdir}/szrt_native_{target}.o')])
# Compile srcdir/szrt_asan.c to szrt_asan_{target}.o
@@ -103,7 +102,7 @@ def MakeRuntimesForTarget(target_info, ll_files,
['-mtriple=' + targets.ConvertTripleToNaCl(target_info.triple)] +
target_info.llc_flags,
TmpFile('{dir}/szrt_sb_{target}.tmp.o'),
- verbose)
+ verbose,target_info.target)
# Assemble srcdir/szrt_asm_{target}.s to tempdir/szrt_asm_{target}.o.
shellcmd(['llvm-mc',
'-triple=' + targets.ConvertTripleToNaCl(target_info.triple),
@@ -118,7 +117,7 @@ def MakeRuntimesForTarget(target_info, ll_files,
['-m {ld_emu}'.format(ld_emu=target_info.sb_emu)],
OutFile('{rtdir}/szrt_sb_{target}.o'),
verbose)
- shellcmd([GetObjcopyCmd(),
+ shellcmd([GetObjcopyCmd(target_info.target),
'--strip-symbol=NACL',
OutFile('{rtdir}/szrt_sb_{target}.o')])
@@ -131,7 +130,7 @@ def MakeRuntimesForTarget(target_info, ll_files,
['-mtriple=' + target_info.triple] + target_info.llc_flags +
['-relocation-model=pic', '-force-tls-non-pic', '-malign-double'],
TmpFile('{dir}/szrt_nonsfi_{target}.tmp.o'),
- verbose)
+ verbose, target_info.target)
# Assemble srcdir/szrt_asm_{target}.s to tempdir/szrt_asm_{target}.o.
shellcmd(['llvm-mc',
'-triple=' + target_info.triple, '--defsym NONSFI=1',
@@ -146,7 +145,7 @@ def MakeRuntimesForTarget(target_info, ll_files,
['-m {ld_emu}'.format(ld_emu=target_info.ld_emu)],
OutFile('{rtdir}/szrt_nonsfi_{target}.o'),
verbose)
- shellcmd([GetObjcopyCmd(),
+ shellcmd([GetObjcopyCmd(target_info.target),
'--strip-symbol=NONSFI',
OutFile('{rtdir}/szrt_nonsfi_{target}.o')])
@@ -211,6 +210,8 @@ def main():
srcdir, tempdir, rtdir, args.verbose)
MakeRuntimesForTarget(targets.ARM32Target, ll_files,
srcdir, tempdir, rtdir, args.verbose)
+ MakeRuntimesForTarget(targets.MIPS32Target, ll_files,
+ srcdir, tempdir, rtdir, args.verbose)
finally:
try:
« no previous file with comments | « Makefile.standalone ('k') | pydir/crosstest.py » ('j') | pydir/crosstest.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698