pydir/run-pnacl-sz.py - Issue 2085303002: Subzero, MIPS32: Cross-testing enabled for MIPS32

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pydir/run-pnacl-sz.py

Issue 2085303002: Subzero, MIPS32: Cross-testing enabled for MIPS32 (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Crosstests running Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pydir/run-pnacl-sz.py

diff --git a/pydir/run-pnacl-sz.py b/pydir/run-pnacl-sz.py

index 580d227b32384523ccd191e5548e7c2b454a422c..d5133e234ac828d0fb808c07f712f01296731daf 100755

--- a/pydir/run-pnacl-sz.py

+++ b/pydir/run-pnacl-sz.py

@@ -20,7 +20,8 @@ def TargetAssemblerFlags(target, sandboxed):

'arm32': ['-triple=%s' % (

'armv7a-nacl' if sandboxed else 'armv7a'),

'-mcpu=cortex-a9', '-mattr=+neon'],

- 'mips32': ['-triple=mipsel' ] }

+ 'mips32': ['-triple=%s' % ('mipsel-nacl' if sandboxed else 'mipsel'),

Jim Stichnoth 2016/08/23 14:56:49 80-col

obucinac 2016/09/05 16:55:59 Done.

+ '-mcpu=mips32'] }

return flags[target]

@@ -203,7 +204,7 @@ def main():

cmd += ['-o', output_file_name]

if args.disassemble:

# Show wide instruction encodings, diassemble, and show relocs.

- cmd += (['&&', os.path.join(pnacl_bin_path, GetObjdumpCmd())] +

+ cmd += (['&&', os.path.join(pnacl_bin_path, GetObjdumpCmd(args.target))] +

args.dis_flags +

['-w', '-d', '-r'] + TargetDisassemblerFlags(args.target) +

[output_file_name])

« pydir/crosstest_generator.py ('K') | « pydir/crosstest_generator.py ('k') | pydir/szbuild.py » ('j') | pydir/targets.py » ('J')