Subzero, MIPS32: Cross-testing enabled for MIPS32

pydir/build-runtime.py

 #!/usr/bin/env python2
 
 import argparse
 import os
 import shutil
 import tempfile
 
 import targets
 from utils import FindBaseNaCl, GetObjcopyCmd, shellcmd
 
 
-def Translate(ll_files, extra_args, obj, verbose):
+def Translate(ll_files, extra_args, obj, verbose, target):
   """Translate a set of input bitcode files into a single object file.
 
   Use pnacl-llc to translate textual bitcode input ll_files into object file
   obj, using extra_args as the architectural flags.
   """
   shellcmd(['cat'] + ll_files + ['|',
             'pnacl-llc',
-            '-externalize',
             '-function-sections',
             '-O2',
             '-filetype=obj',
             '-bitcode-format=llvm',
             '-arm-enable-dwarf-eh=1',
             '-o', obj
     ] + extra_args, echo=verbose)
-  shellcmd([GetObjcopyCmd(),
+  shellcmd([GetObjcopyCmd(target),
             '--strip-symbol=nacl_tp_tdb_offset',
             '--strip-symbol=nacl_tp_tls_offset',
             obj
     ], echo=verbose)
 
 
 def PartialLink(obj_files, extra_args, lib, verbose):
   """Partially links a set of obj files into a final obj library."""
   shellcmd(['le32-nacl-ld',
             '-o', lib,
@@ skipping 10 matching lines @@
   def OutFile(template):
     return template.format(rtdir=rtdir, target=target_info.target)
   # Helper function for building the native unsandboxed runtime.
   def MakeNativeRuntime():
     """Builds just the native runtime."""
     # Translate tempdir/szrt.ll and tempdir/szrt_ll.ll to
     # szrt_native_{target}.tmp.o.
     Translate(ll_files,
               ['-mtriple=' + target_info.triple] + target_info.llc_flags,
               TmpFile('{dir}/szrt_native_{target}.tmp.o'),
-              verbose)
+              verbose,target=target_info.target)
     # Compile srcdir/szrt_profiler.c to
     # tempdir/szrt_profiler_native_{target}.o.
     shellcmd(['clang',
               '-O2',
               '-target=' + target_info.triple,
               '-c',
               '{srcdir}/szrt_profiler.c'.format(srcdir=srcdir),
               '-o', TmpFile('{dir}/szrt_native_profiler_{target}.o')
-      ], echo=verbose)
+            ], echo=verbose)

[Jim Stichnoth, 2016/08/23 14:56:48]

revert this whitespace change

[obucinac, 2016/09/05 16:55:59]

Done.

     # Assemble srcdir/szrt_asm_{target}.s to tempdir/szrt_asm_{target}.o.
     shellcmd(['llvm-mc',
               '-triple=' + target_info.triple, '--defsym NATIVE=1',
               '-filetype=obj',
               '-o', TmpFile('{dir}/szrt_native_asm_{target}.o'),
               '{srcdir}/szrt_asm_{target}.s'.format(
                 srcdir=srcdir, target=target_info.target)
       ], echo=verbose)
     # Write full szrt_native_{target}.o.
     PartialLink([TmpFile('{dir}/szrt_native_{target}.tmp.o'),
                  TmpFile('{dir}/szrt_native_asm_{target}.o'),
                  TmpFile('{dir}/szrt_native_profiler_{target}.o')],
                 ['-m {ld_emu}'.format(ld_emu=target_info.ld_emu)],
                 OutFile('{rtdir}/szrt_native_{target}.o'),
                 verbose)
-    shellcmd([GetObjcopyCmd(),
+    shellcmd([GetObjcopyCmd(target=target_info.target),

[Jim Stichnoth, 2016/08/23 14:56:48]

Can you remove "target=" ?

here and below

[obucinac, 2016/09/05 16:55:59]

Done.

               '--strip-symbol=NATIVE',
               OutFile('{rtdir}/szrt_native_{target}.o')])
     # Compile srcdir/szrt_asan.c to szrt_asan_{target}.o
     shellcmd(['clang',
               '-O2',
               '-target=' + target_info.triple,
               '-c',
               '{srcdir}/szrt_asan.c'.format(srcdir=srcdir),
               '-o', OutFile('{rtdir}/szrt_asan_{target}.o')
       ], echo=verbose)
 
   # Helper function for building the sandboxed runtime.
   def MakeSandboxedRuntime():
     """Builds just the sandboxed runtime."""
     # Translate tempdir/szrt.ll and tempdir/szrt_ll.ll to szrt_sb_{target}.o.
     # The sandboxed library does not get the profiler helper function as the
     # binaries are linked with -nostdlib.
     Translate(ll_files,
               ['-mtriple=' + targets.ConvertTripleToNaCl(target_info.triple)] +
               target_info.llc_flags,
               TmpFile('{dir}/szrt_sb_{target}.tmp.o'),
-              verbose)
+              verbose,target=target_info.target)
     # Assemble srcdir/szrt_asm_{target}.s to tempdir/szrt_asm_{target}.o.
     shellcmd(['llvm-mc',
               '-triple=' + targets.ConvertTripleToNaCl(target_info.triple),
               '--defsym NACL=1',
               '-filetype=obj',
               '-o', TmpFile('{dir}/szrt_sb_asm_{target}.o'),
               '{srcdir}/szrt_asm_{target}.s'.format(
                 srcdir=srcdir, target=target_info.target)
       ], echo=verbose)
     PartialLink([TmpFile('{dir}/szrt_sb_{target}.tmp.o'),
                  TmpFile('{dir}/szrt_sb_asm_{target}.o')],
                 ['-m {ld_emu}'.format(ld_emu=target_info.sb_emu)],
                 OutFile('{rtdir}/szrt_sb_{target}.o'),
                 verbose)
-    shellcmd([GetObjcopyCmd(),
+    shellcmd([GetObjcopyCmd(target=target_info.target),
               '--strip-symbol=NACL',
               OutFile('{rtdir}/szrt_sb_{target}.o')])
 
   # Helper function for building the Non-SFI runtime.
   def MakeNonsfiRuntime():
     """Builds just the nonsfi runtime."""
     # Translate tempdir/szrt.ll and tempdir/szrt_ll.ll to
     # szrt_nonsfi_{target}.tmp.o.
     Translate(ll_files,
               ['-mtriple=' + target_info.triple] + target_info.llc_flags +
               ['-relocation-model=pic', '-force-tls-non-pic', '-malign-double'],
               TmpFile('{dir}/szrt_nonsfi_{target}.tmp.o'),
-              verbose)
+              verbose, target=target_info.target)
     # Assemble srcdir/szrt_asm_{target}.s to tempdir/szrt_asm_{target}.o.
     shellcmd(['llvm-mc',
               '-triple=' + target_info.triple, '--defsym NONSFI=1',
               '-filetype=obj',
               '-o', TmpFile('{dir}/szrt_nonsfi_asm_{target}.o'),
               '{srcdir}/szrt_asm_{target}.s'.format(
                 srcdir=srcdir, target=target_info.target)
       ], echo=verbose)
     # Write full szrt_nonsfi_{target}.o.
     PartialLink([TmpFile('{dir}/szrt_nonsfi_{target}.tmp.o'),
                  TmpFile('{dir}/szrt_nonsfi_asm_{target}.o')],
                 ['-m {ld_emu}'.format(ld_emu=target_info.ld_emu)],
                 OutFile('{rtdir}/szrt_nonsfi_{target}.o'),
                 verbose)
-    shellcmd([GetObjcopyCmd(),
+    shellcmd([GetObjcopyCmd(target=target_info.target),
               '--strip-symbol=NONSFI',
               OutFile('{rtdir}/szrt_nonsfi_{target}.o')])
 
 
   # Run the helper functions.
   MakeNativeRuntime()
   MakeSandboxedRuntime()
   MakeNonsfiRuntime()
 
 
@@ skipping 44 matching lines @@
             ], echo=args.verbose)
         ll_files = ['{dir}/szrt.ll'.format(dir=tempdir),
                     '{srcdir}/szrt_ll.ll'.format(srcdir=srcdir)]
 
         MakeRuntimesForTarget(targets.X8632Target, ll_files,
                               srcdir, tempdir, rtdir, args.verbose)
         MakeRuntimesForTarget(targets.X8664Target, ll_files,
                               srcdir, tempdir, rtdir, args.verbose)
         MakeRuntimesForTarget(targets.ARM32Target, ll_files,
                               srcdir, tempdir, rtdir, args.verbose)
+        MakeRuntimesForTarget(targets.MIPS32Target, ll_files,

[Jim Stichnoth, 2016/09/02 15:49:31]

We need a way to not run this in a non-MIPS build environment.

It's probably best to control that via a command-line flag in this script.

Maybe add something like this above:

    argparser.add_argument('--exclude-target', dest='exclude_target',
                           default=[], action='append',
                           help='Target whose runtime should not be built')

And then pass args.exclude_target as an additional argument to
MakeRuntimesForTarget().  And at the top of MakeRuntimesForTarget(), do an early
exit:

  if target_info.target in excluded_targets:
    return

Then the Makefile.standalone needs some special MIPS controls for RT_SRC and
RT_OBJ.

I think this could be effectively tested for non-MIPS by temporarily defining
FindMIPSCrossInclude() to glob a nonexistent directory.

+                              srcdir, tempdir, rtdir, args.verbose)
 
     finally:
         try:
             shutil.rmtree(tempdir)
         except OSError as exc:
             if exc.errno != errno.ENOENT: # ENOENT - no such file or directory
                 raise # re-raise exception
 
 if __name__ == '__main__':
     main()