Subzero, MIPS32: Cross-testing enabled for MIPS32

Makefile.standalone

 # The following variables will likely need to be modified, depending on where
 # and how you built LLVM & Clang. They can be overridden in a command-line
 # invocation of make, like:
 #
 #   make LLVM_SRC_PATH=<path> LIBCXX_INSTALL_PATH=<path> CLANG_PATH=<path> \
 #        PNACL_BIN_PATH=<path> ...
 #
 
 # LLVM_SRC_PATH is the path to the root of the checked out source code. This
 # directory should contain the configure script, the include/ and lib/
@@ skipping 392 matching lines @@
         @$(SHOW_BUILD_ATTS)
 
 sb_make_symlink: $(NEXES)
         $(foreach nexe,$(NEXES),rm -rf $(notdir $(nexe)); ln -s $(nexe);)
 
 %.pexe : %.nonfinal.pexe
         $(SB_FINALIZE) -o $@ $<
 
 .PHONY: all compile_only make_symlink runtime bloat sb docs help \
   help-check-lit help-check-xtest exists-nonsfi-x8632 \
-  exists-nonsfi-arm32 exists-sbtc exists-spec
+  exists-nonsfi-arm32 exists-nonsfi-mips32 exists-sbtc exists-spec

[Jim Stichnoth, 2016/06/22 19:14:16]

I'm not sure we should bother with the "nonsfi" feature for MIPS.

We implemented "nonsfi" mode in Subzero for another group here, but they have
since moved on and I believe they are not using Subzero any more.

The main priority for Chrome is "sandbox" code generation, however for the
initial bring-up and testing and tuning, "native" code generation is much more
convenient.

 
 compile_only: $(OBJS)
 
 V8_LIBDIR=$(V8_DIR)/out/native/lib.target
 
 ifdef WASM
   V8_LIBS := \
     $(V8_LIBDIR)/libv8.so \
     $(V8_LIBDIR)/libicuuc.so \
     $(V8_LIBDIR)/libicui18n.so
@@ skipping 100 matching lines @@
 check-lit: $(OBJDIR)/pnacl-sz make_symlink
         PNACL_BIN_PATH=$(PNACL_BIN_PATH) \
         $(LLVM_SRC_PATH)/utils/lit/lit.py -sv $(CHECK_LIT_TESTS) \
             $(FORCEASM_LIT_TEST_EXCLUDES) $(FORCEASM_LIT_PARAM)
 
 ifdef MINIMAL
 check-xtest check-xtest-lite: $(OBJDIR)/pnacl-sz make_symlink runtime
         @echo "Crosstests disabled, minimal build"
 else
 check-xtest: $(OBJDIR)/pnacl-sz make_symlink runtime \
-  exists-nonsfi-x8632 exists-nonsfi-arm32 crosstest/test_arith_ll.ll
+  exists-nonsfi-x8632 exists-nonsfi-arm32 exists-nonsfi-mips32 crosstest/test_arith_ll.ll
        # Do all native/sse2 tests, but only test_vector_ops for native/sse4.1.
        # For (slow) sandboxed tests, limit to Om1/sse4.1.
        # run.py (used to run the sandboxed xtests) does not support
        # specifying -cpu cortex-a15 to qemu, hence we disable the
        # hwdiv-arm tests.
         ./pydir/crosstest_generator.py -v --lit \
           --toolchain-root $(TOOLCHAIN_ROOT) \
           $(FORCEASM_FLAG) \
           $(FORCEASM_XTEST_EXCLUDES) \
           -i x8632,native,sse2 \
           -i x8632,native,sse4.1,test_vector_ops \
           -i x8632,sandbox,sse4.1,Om1 \
           -i x8632,nonsfi,sse2,O2 \
           -i x8664,native,sse2 \
           -i x8664,native,sse4.1,test_vector_ops \
           -i x8664,sandbox,sse4.1,Om1 \
           -i arm32 \
+          -i mips32 \

[Jim Stichnoth, 2016/06/22 19:14:16]

I don't think any of the MIPS cross tests are ready yet to be enabled, because
each cross test has some missing MIPS lowering functionality.

Also, cross tests use --filetype=obj by default unless FORCEASM is used in the
makefile, so the MIPS cross tests will all fail anyway until --filetype=obj is
ready.

Because of this, you should not add any "-i mips32" arguments here because "make
check-xtest" will fail.

Later, I would start with "simple_loop" which is the simplest of the cross
tests.  It currently fails because the "load" instruction is not yet
implemented, also O2 fails because some of the O2 machinery is not yet
implemented.  But after the load instruction is implemented:

./pydir/crosstest_generator.py -v --filetype=asm --toolchain-root
/path/to/native_client/toolchain/linux_x86 -i mips32,native,Om1,simple_loop

should work.

+          -i mips32,native \
           -e arm32,sandbox,hwdiv-arm
         PNACL_BIN_PATH=$(PNACL_BIN_PATH) \
         $(LLVM_SRC_PATH)/utils/lit/lit.py -sv $(CHECK_XTEST_TESTS)
 check-xtest-lite: $(OBJDIR)/pnacl-sz make_symlink runtime \
-  exists-nonsfi-x8632 exists-nonsfi-arm32 crosstest/test_arith_ll.ll
+  exists-nonsfi-x8632 exists-nonsfi-arm32 exists-nonsfi-mips32 crosstest/test_arith_ll.ll
        # Do all native/sse2/neon tests, which are relatively fast.
        # Limit to test_global+mem_intrin for sandbox+nonsfi because sandbox and
        # nonsfi builds are slow, and test_global and mem_intrin are the most
        # common sources of problems.
         ./pydir/crosstest_generator.py -v --lit \
           --toolchain-root $(TOOLCHAIN_ROOT) \
           $(FORCEASM_FLAG) \
           $(FORCEASM_XTEST_EXCLUDES) \
           -i x8632,native,sse2,O2 \
           -i x8664,native,sse2,O2 \
@@ skipping 30 matching lines @@
 ifeq ($(TARGET),x8664)
   TARGETFLAG=x8664
   SETUP=SetupGccX8664Opt
   SPEC := --filetype=obj
 endif
 ifeq ($(TARGET),arm32)
   TARGETFLAG=arm32
   SETUP=SetupGccArmOpt
   SPEC := --filetype=obj
 endif
+ifeq ($(TARGET),mips32)
+  TARGETFLAG=mips32
+  SETUP=SetupGccMipsOpt
+  SPEC := --filetype=obj
+endif
 SPECFLAGS := -O2
 SPECRUN := --run
 %.spec2k: % $(OBJDIR)/pnacl-sz make_symlink runtime
         ./pydir/szbuild_spec2k.py -v \
           $(SPECFLAGS) --target=$(TARGETFLAG) $(SPEC) $< $(SPECRUN)
 
 check-spec: exists-spec $(ALLSPEC:=.spec2k)
 
 check: check-lit check-unit check-xtest
 
+NONSFI_LOADER_MIPS32 =\
+  $(NACL_ROOT)/scons-out/opt-linux-mips32/obj/src/nonsfi/loader/nonsfi_loader
+
 NONSFI_LOADER_X8632 = \
   $(NACL_ROOT)/scons-out/opt-linux-x86-32/obj/src/nonsfi/loader/nonsfi_loader
 NONSFI_LOADER_ARM32 = \
   $(NACL_ROOT)/scons-out/opt-linux-arm/obj/src/nonsfi/loader/nonsfi_loader
 SBTC_LIBFILE = $(SB_LLVM_PATH)/lib/libLLVMSupport.a
 SPEC_SAMPLE_PEXE = $(NACL_ROOT)/tests/spec2k/176.gcc/gcc.opt.stripped.pexe
 
 exists-nonsfi-x8632:
         @if [ ! -f $(NONSFI_LOADER_X8632) ] ; then \
           echo "Missing file $(NONSFI_LOADER_X8632)"; \
           echo "Consider running './scons nonsfi_loader'" \
                "in the native_client directory."; \
           exit 1 ; \
         fi
 
 exists-nonsfi-arm32:
         @if [ ! -f $(NONSFI_LOADER_ARM32) ] ; then \
           echo "Missing file $(NONSFI_LOADER_ARM32)"; \
           echo "Consider running './scons platform=arm nonsfi_loader'" \
                "in the native_client directory."; \
           exit 1 ; \
         fi
 
+exists-nonsfi-mips32:
+        @if [ ! -f $(NONSFI_LOADER_MIPS32) ] ; then \
+          echo "Missing file $(NONSFI_LOADER_MIPS32)"; \
+          echo "Consider running './scons platform=mips nonsfi_loader'" \
+               "in the native_client directory."; \
+          exit 1 ; \
+        fi
+
 exists-sbtc:
         @if [ ! -f $(SBTC_LIBFILE) ] ; then \
           echo "Missing file $(SBTC_LIBFILE)"; \
           echo "Consider running 'toolchain_build_pnacl.py --build-sbtc'."; \
           exit 1 ; \
         fi
 
 exists-spec:
         @if [ ! -f $(SPEC_SAMPLE_PEXE) ] ; then \
           echo "Missing file $(SPEC_SAMPLE_PEXE)"; \
           echo "Consider running" \
                "'./run_all.sh BuildBenchmarks 0 SetupPnaclX8632Opt'" \
                "in the native_client/tests/spec2k directory."; \
           exit 1 ; \
         fi
 
 check-presubmit presubmit: exists-nonsfi-x8632 exists-nonsfi-arm32 \
-  exists-sbtc exists-spec
+  exists-nonsfi-mips32 exists-sbtc exists-spec
 # Make sure clang-format gets run.
         +make -f Makefile.standalone format
 # Verify MINIMAL build, plus proper usage of REQUIRES in lit tests.
         +make -f Makefile.standalone \
           MINIMAL=1 check
 # Check that there are no g++ build errors or warnings.
         +make -f Makefile.standalone \
           GPLUSPLUS=1 compile_only
 # Check the x86 assembler unit tests.
         +make -f Makefile.standalone \
@@ skipping 29 matching lines @@
         +make -f Makefile.standalone \
           TARGET=arm32 SPECFLAGS='-Om1' SPECRUN= check-spec
 # Run a few spec2k tests for arm32 using qemu. Keep the list sorted in
 # roughly reverse order of runtime.
         +make -f Makefile.standalone \
           TARGET=arm32 ALLSPEC='252.eon 254.gap 176.gcc 181.mcf' check-spec
 # Provide validation of user awesomeness!
         echo Success
 
 presubmit-lite: exists-nonsfi-x8632 exists-nonsfi-arm32 \
-  exists-sbtc exists-spec
+  exists-nonsfi-mips32 exists-sbtc exists-spec
 # Make sure clang-format gets run.
         +make -f Makefile.standalone format
 # Verify MINIMAL build, plus proper usage of REQUIRES in lit tests.
         +make -f Makefile.standalone \
           MINIMAL=1 check sb-lite
 # Check that there are no g++ build errors or warnings.
         +make -f Makefile.standalone \
           GPLUSPLUS=1 compile_only
 # Run lit tests, cross tests, unit tests, and spec2k/x86-32.
         +make -f Makefile.standalone \
@@ skipping 64 matching lines @@
 
 help-check-xtest:
         @cat Makefile.standalone-help/check-xtest.txt
 
 clean:
         rm -rf pnacl-sz *.o $(foreach nexe,$(NEXES),$(notdir $(nexe))) \
           $(OBJDIR) $(SB_OBJDIR) $(SBB_OBJDIR) build/*.bloat.json
 
 clean-all: clean
         rm -rf build/ crosstest/Output/