device/bluetooth/bluetooth_remote_gatt_characteristic_win.cc - Issue 2085293002: bluetooth: Call GattCharacteristicValueChanged after a read succeeds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluetooth_remote_gatt_characteristic_win.cc

Issue 2085293002: bluetooth: Call GattCharacteristicValueChanged after a read succeeds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin

Patch Set: Use a lambda to check that GattCharacteristicValueChanged has been called Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc ('k') | device/bluetooth/test/test_bluetooth_adapter_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/bluetooth_remote_gatt_characteristic_win.cc

diff --git a/device/bluetooth/bluetooth_remote_gatt_characteristic_win.cc b/device/bluetooth/bluetooth_remote_gatt_characteristic_win.cc

index 3f306f01901c8fb52066f1845a30dc82f77f09c3..aec99968c82741c815827abe2ca6c946067be558 100644

--- a/device/bluetooth/bluetooth_remote_gatt_characteristic_win.cc

+++ b/device/bluetooth/bluetooth_remote_gatt_characteristic_win.cc

@@ -358,6 +358,10 @@ void BluetoothRemoteGattCharacteristicWin::

characteristic_value_.clear();

for (ULONG i = 0; i < value->DataSize; i++)

characteristic_value_.push_back(value->Data[i]);

+ parent_service_->GetWinAdapter()->NotifyGattCharacteristicValueChanged(

+ this, characteristic_value_);

callbacks.first.Run(characteristic_value_);

}

characteristic_value_read_or_write_in_progress_ = false;