device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc - Issue 2085293002: bluetooth: Call GattCharacteristicValueChanged after a read succeeds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc

Issue 2085293002: bluetooth: Call GattCharacteristicValueChanged after a read succeeds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin

Patch Set: Use a lambda to check that GattCharacteristicValueChanged has been called Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc

diff --git a/device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc b/device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc

index 2e3b81d9881124318b6f1131cdf3b067b1c0449a..a269ff8819aaa70117888231d571ccb2aea6cb80 100644

--- a/device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc

+++ b/device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc

@@ -284,8 +284,8 @@ void BluetoothRemoteGattCharacteristicAndroid::OnRead(

if (status == 0 // android.bluetooth.BluetoothGatt.GATT_SUCCESS

&& !read_callback.is_null()) {

base::android::JavaByteArrayToByteVector(env, value, &value_);

+ adapter_->NotifyGattCharacteristicValueChanged(this, value_);

read_callback.Run(value_);

- // TODO(https://crbug.com/545682): Call GattCharacteristicValueChanged.

} else if (!read_error_callback.is_null()) {

read_error_callback.Run(

BluetoothRemoteGattServiceAndroid::GetGattErrorCode(status));

« no previous file with comments | « no previous file | device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc » ('j') | no next file with comments »