Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1930)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc

Issue 2085293002: bluetooth: Call GattCharacteristicValueChanged after a read succeeds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin
Patch Set: Add windows Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc » ('j') | device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc
diff --git a/device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc b/device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc
index 2e3b81d9881124318b6f1131cdf3b067b1c0449a..a269ff8819aaa70117888231d571ccb2aea6cb80 100644
--- a/device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc
+++ b/device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc
@@ -284,8 +284,8 @@ void BluetoothRemoteGattCharacteristicAndroid::OnRead(
if (status == 0 // android.bluetooth.BluetoothGatt.GATT_SUCCESS
&& !read_callback.is_null()) {
base::android::JavaByteArrayToByteVector(env, value, &value_);
+ adapter_->NotifyGattCharacteristicValueChanged(this, value_);
read_callback.Run(value_);
- // TODO(https://crbug.com/545682): Call GattCharacteristicValueChanged.
} else if (!read_error_callback.is_null()) {
read_error_callback.Run(
BluetoothRemoteGattServiceAndroid::GetGattErrorCode(status));
« no previous file with comments | « no previous file | device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc » ('j') | device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698