Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 208523005: Remove unused animation code after SVG prop migration (Closed)

Created:
6 years, 9 months ago by pdr.
Modified:
6 years, 9 months ago
Reviewers:
kouhei (in TOK)
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), rwlbuis, fs, kouhei+svg_chromium.org, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Steve Block, dino_apple.com, pdr., Eric Willigers
Visibility:
Public.

Description

Remove unused animation code after SVG prop migration After the migration to the new SVG property implementation, some unused functions were left. This patch removes the remainder of the unused functions. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169828

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -43 lines) Patch
M Source/core/svg/SVGAnimationElement.h View 2 chunks +0 lines, -36 lines 0 comments Download
M Source/core/svg/properties/SVGAnimatedProperty.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/properties/SVGAnimatedProperty.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pdr.
6 years, 9 months ago (2014-03-24 03:29:19 UTC) #1
kouhei (in TOK)
lgtm. Thanks for clean up!
6 years, 9 months ago (2014-03-24 03:40:51 UTC) #2
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 9 months ago (2014-03-24 03:40:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/208523005/1
6 years, 9 months ago (2014-03-24 03:40:58 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-24 06:56:59 UTC) #5
Message was sent while issue was closed.
Change committed as 169828

Powered by Google App Engine
This is Rietveld 408576698