Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(23)

Issue 2085223002: Add HasOwnProperty with array indexes (Closed)

Created:
2 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
2 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
PaweĊ‚ Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add HasOwnProperty with array indexes This way embedders don't have to manually convert them to strings BUG=chromium:619166 R=verwaest@chromium.org Committed: https://crrev.com/c7715c2fbee025f69acc539f8620b7d423d5c3e8 Cr-Commit-Position: refs/heads/master@{#37179}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
M include/v8.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/api.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/objects.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 2 chunks +19 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jochen (gone - plz use gerrit)
2 years, 11 months ago (2016-06-22 09:33:34 UTC) #1
Toon Verwaest
https://codereview.chromium.org/2085223002/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/2085223002/diff/1/src/api.cc#newcode4191 src/api.cc:4191: context, Utils::ToLocal(isolate->factory()->Uint32ToString(index))); You'll want to add a JSReceiver::HasOwnProperty with ...
2 years, 11 months ago (2016-06-22 09:41:31 UTC) #2
jochen (gone - plz use gerrit)
ptal
2 years, 11 months ago (2016-06-22 09:48:49 UTC) #3
Toon Verwaest
lgtm, thanks
2 years, 11 months ago (2016-06-22 09:55:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085223002/20001
2 years, 11 months ago (2016-06-22 09:56:42 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
2 years, 11 months ago (2016-06-22 10:18:50 UTC) #7
commit-bot: I haz the power
2 years, 11 months ago (2016-06-22 10:20:57 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c7715c2fbee025f69acc539f8620b7d423d5c3e8
Cr-Commit-Position: refs/heads/master@{#37179}

Powered by Google App Engine
This is Rietveld 408576698