Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2085203002: Add missing define for Mojo NaCl build on ChromeOS. (Closed)

Created:
4 years, 6 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing define for Mojo NaCl build on ChromeOS. Missed one after rebasing crrev.com/400894 before submitting. BUG=604282 Committed: https://crrev.com/2ed4599b7f23d2f9073c91488673d214cf2071f0 Cr-Commit-Position: refs/heads/master@{#401210}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M mojo/mojo_edk_nacl.gyp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085203002/1
4 years, 6 months ago (2016-06-22 04:07:41 UTC) #2
Anand Mistry (off Chromium)
4 years, 6 months ago (2016-06-22 04:07:55 UTC) #4
Ken Rockot(use gerrit already)
lgtm
4 years, 6 months ago (2016-06-22 04:15:59 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-22 04:50:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085203002/1
4 years, 6 months ago (2016-06-22 04:57:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 05:02:06 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 05:04:00 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ed4599b7f23d2f9073c91488673d214cf2071f0
Cr-Commit-Position: refs/heads/master@{#401210}

Powered by Google App Engine
This is Rietveld 408576698