Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2085183002: PPC/s390: [builtins] NonNumberToNumber and StringToNumber now use CallRuntime instead of TailCallRu… (Closed)

Created:
4 years, 6 months ago by JaideepBajwa
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [builtins] NonNumberToNumber and StringToNumber now use CallRuntime instead of TailCallRuntime Port b5c69cbf39192b7efc12ae40406c8bd55a44419b Original commit message: With the tail call, pointers to the JS heap could be pushed on a js-to-wasm frame. On the js-to-wasm frame, however, this pointer would not be updated by the GC. R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=617084 LOG=N Committed: https://crrev.com/97c21548696c4a5922903aadb1c439fa16ab16c5 Cr-Commit-Position: refs/heads/master@{#37160}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -8 lines) Patch
M src/ppc/builtins-ppc.cc View 2 chunks +18 lines, -4 lines 0 comments Download
M src/s390/builtins-s390.cc View 2 chunks +18 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 6 months ago (2016-06-22 02:05:54 UTC) #1
JoranSiu
On 2016/06/22 02:05:54, JaideepBajwa wrote: > PTAL lgtm
4 years, 6 months ago (2016-06-22 02:16:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085183002/1
4 years, 6 months ago (2016-06-22 02:17:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 02:37:28 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 02:38:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97c21548696c4a5922903aadb1c439fa16ab16c5
Cr-Commit-Position: refs/heads/master@{#37160}

Powered by Google App Engine
This is Rietveld 408576698