Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2085173003:
WeakPtr requires SequencedTaskRunner, correct interface in blimp_client_session.cc (Closed)
|
Created:
4 years, 6 months ago by gab Modified:
4 years, 6 months ago Reviewers:
Wez CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@c1_task_runner_handle Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionWeakPtr requires SequencedTaskRunner, correct interface in blimp_client_session.cc
The caller is already using a SequencedTaskRunner but it's incorrect for this
interface to allow a plain TaskRunner per its use of WeakPtr.
BUG=618043
Committed: https://crrev.com/9f79bb50c6a36522eac9e0fb327c644ffb09c405
Cr-Commit-Position: refs/heads/master@{#401431}
Patch Set 1 #
Total comments: 2
Patch Set 2 : DISALLOW_COPY_AND_ASSIGN #Patch Set 3 : rm dependency #Messages
Total messages: 24 (14 generated)
Description was changed from ========== WeakPtr requires SequencedTaskRunner, correct interface in blimp_client_session.cc BUG=553459 ========== to ========== WeakPtr requires SequencedTaskRunner, correct interface in blimp_client_session.cc BUG=553459 NO_DEPENDENCY_CHECKS=true ==========
Description was changed from ========== WeakPtr requires SequencedTaskRunner, correct interface in blimp_client_session.cc BUG=553459 NO_DEPENDENCY_CHECKS=true ========== to ========== WeakPtr requires SequencedTaskRunner, correct interface in blimp_client_session.cc The caller is already using a SequencedTaskRunner but it's incorrect for this interface to allow a plain TaskRunner per its use of WeakPtr. BUG=618043 NO_DEPENDENCY_CHECKS=true ==========
gab@chromium.org changed reviewers: + wez@chromium.org
Wez PTAL (and CQ if it LGTYs)
LGTM w/ nit. https://codereview.chromium.org/2085173003/diff/1/blimp/client/session/blimp_... File blimp/client/session/blimp_client_session.cc (right): https://codereview.chromium.org/2085173003/diff/1/blimp/client/session/blimp_... blimp/client/session/blimp_client_session.cc:69: }; DISALLOW_COPY_AND_ASSIGN here, as well.
Thanks, done https://codereview.chromium.org/2085173003/diff/1/blimp/client/session/blimp_... File blimp/client/session/blimp_client_session.cc (right): https://codereview.chromium.org/2085173003/diff/1/blimp/client/session/blimp_... blimp/client/session/blimp_client_session.cc:69: }; On 2016/06/22 18:31:28, Wez wrote: > DISALLOW_COPY_AND_ASSIGN here, as well. Done.
The CQ bit was checked by gab@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from wez@chromium.org Link to the patchset: https://codereview.chromium.org/2085173003/#ps20001 (title: "DISALLOW_COPY_AND_ASSIGN")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085173003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== WeakPtr requires SequencedTaskRunner, correct interface in blimp_client_session.cc The caller is already using a SequencedTaskRunner but it's incorrect for this interface to allow a plain TaskRunner per its use of WeakPtr. BUG=618043 NO_DEPENDENCY_CHECKS=true ========== to ========== WeakPtr requires SequencedTaskRunner, correct interface in blimp_client_session.cc The caller is already using a SequencedTaskRunner but it's incorrect for this interface to allow a plain TaskRunner per its use of WeakPtr. BUG=618043 NO_DEPENDENCY_CHECKS=true TBR=workingarounsillydepcheckissue ==========
The CQ bit was checked by gab@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085173003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
Description was changed from ========== WeakPtr requires SequencedTaskRunner, correct interface in blimp_client_session.cc The caller is already using a SequencedTaskRunner but it's incorrect for this interface to allow a plain TaskRunner per its use of WeakPtr. BUG=618043 NO_DEPENDENCY_CHECKS=true TBR=workingarounsillydepcheckissue ========== to ========== WeakPtr requires SequencedTaskRunner, correct interface in blimp_client_session.cc The caller is already using a SequencedTaskRunner but it's incorrect for this interface to allow a plain TaskRunner per its use of WeakPtr. BUG=618043 ==========
The CQ bit was checked by gab@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from wez@chromium.org Link to the patchset: https://codereview.chromium.org/2085173003/#ps40001 (title: "rm dependency")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085173003/40001
Message was sent while issue was closed.
Description was changed from ========== WeakPtr requires SequencedTaskRunner, correct interface in blimp_client_session.cc The caller is already using a SequencedTaskRunner but it's incorrect for this interface to allow a plain TaskRunner per its use of WeakPtr. BUG=618043 ========== to ========== WeakPtr requires SequencedTaskRunner, correct interface in blimp_client_session.cc The caller is already using a SequencedTaskRunner but it's incorrect for this interface to allow a plain TaskRunner per its use of WeakPtr. BUG=618043 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== WeakPtr requires SequencedTaskRunner, correct interface in blimp_client_session.cc The caller is already using a SequencedTaskRunner but it's incorrect for this interface to allow a plain TaskRunner per its use of WeakPtr. BUG=618043 ========== to ========== WeakPtr requires SequencedTaskRunner, correct interface in blimp_client_session.cc The caller is already using a SequencedTaskRunner but it's incorrect for this interface to allow a plain TaskRunner per its use of WeakPtr. BUG=618043 Committed: https://crrev.com/9f79bb50c6a36522eac9e0fb327c644ffb09c405 Cr-Commit-Position: refs/heads/master@{#401431} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/9f79bb50c6a36522eac9e0fb327c644ffb09c405 Cr-Commit-Position: refs/heads/master@{#401431} |
