Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2085153003: [Interpreter] Switch functions from ignition to full-codegen sooner. (Closed)

Created:
4 years, 6 months ago by mythria
Modified:
4 years, 6 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Switch functions from ignition to full-codegen early. Updates kProfilerTicksBeforeBaseline in runtime-profiler to allow functions to switch from ignition to full-codgen earlier. This helps on many benchmarks and does not impact the code size significantly. BUG=v8:4280 LOG=N Committed: https://crrev.com/dc4faa623c73c489551769845e4b6a3984b9d937 Cr-Commit-Position: refs/heads/master@{#37189}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/runtime-profiler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
mythria
PTAL. Thanks, Mythri
4 years, 6 months ago (2016-06-22 11:46:48 UTC) #4
rmcilroy
LGTM, hopefully the bots agree. Thanks.
4 years, 6 months ago (2016-06-22 11:53:07 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085153003/1
4 years, 6 months ago (2016-06-22 13:31:01 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-22 13:54:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085153003/1
4 years, 6 months ago (2016-06-22 14:39:30 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 14:41:13 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 14:42:09 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dc4faa623c73c489551769845e4b6a3984b9d937
Cr-Commit-Position: refs/heads/master@{#37189}

Powered by Google App Engine
This is Rietveld 408576698