Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2085153002: Adjust test expectations for infinite-size images. (Closed)

Created:
4 years, 6 months ago by Bret
Modified:
4 years, 6 months ago
Reviewers:
Mike West, oshima
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo, jam, darin-cc_chromium.org, blink-reviews, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust test expectations for infinite-size images. The test for infinite-size images is expecting the width to be equal to the maximum possible value of a blink layout value. However, with use-zoom-for-dsf on and device scale factor !=1 all image widths are adjusted by the scale factor. So the test's expectation needs to be changed because the effective maximum value is now different. BUG=622000 Committed: https://crrev.com/e691b41f4226ecb00323a46fedb97d0ae2b67047 Cr-Commit-Position: refs/heads/master@{#401397}

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 4

Patch Set 3 : small refactor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -3 lines) Patch
M components/test_runner/test_runner_for_specific_view.cc View 1 2 1 chunk +8 lines, -1 line 0 comments Download
M components/test_runner/web_test_delegate.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-intrinsic-size-zero.html View 1 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/resources/srcset-helper.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
Bret
4 years, 6 months ago (2016-06-22 00:51:10 UTC) #3
oshima
non owner lgtm with a nit https://codereview.chromium.org/2085153002/diff/20001/components/test_runner/web_test_delegate.h File components/test_runner/web_test_delegate.h (right): https://codereview.chromium.org/2085153002/diff/20001/components/test_runner/web_test_delegate.h#newcode159 components/test_runner/web_test_delegate.h:159: // Returns whether ...
4 years, 6 months ago (2016-06-22 01:11:51 UTC) #4
Bret
https://codereview.chromium.org/2085153002/diff/20001/components/test_runner/web_test_delegate.h File components/test_runner/web_test_delegate.h (right): https://codereview.chromium.org/2085153002/diff/20001/components/test_runner/web_test_delegate.h#newcode159 components/test_runner/web_test_delegate.h:159: // Returns whether or not the use-zoom-for-dsf flag is ...
4 years, 6 months ago (2016-06-22 17:42:27 UTC) #5
Mike West
On 2016/06/22 at 01:11:51, oshima wrote: > I have a slight preference to have a ...
4 years, 6 months ago (2016-06-22 18:57:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085153002/40001
4 years, 6 months ago (2016-06-22 19:28:14 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-22 20:56:40 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 20:58:43 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e691b41f4226ecb00323a46fedb97d0ae2b67047
Cr-Commit-Position: refs/heads/master@{#401397}

Powered by Google App Engine
This is Rietveld 408576698