Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2085143003:
[Interpreter] Fix missing entries for bytecode handlers in perf mapping. (Closed)
|
Created:
4 years, 6 months ago by Stefano Sanfilippo Modified:
4 years, 6 months ago CC:
v8-reviews_googlegroups.com, Yang Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[Interpreter] Fix missing entries for bytecode handlers in perf mapping.
Since [1], Logger does not dispatch anymore to the other loggers. This is
now the task of the CodeEventDispatcher, and Logger is just a client.
One use of the Logger as dispatcher wasn't caught in the refactoring, which
caused the entries for bytecode handlers loaded from the snapshot to be
missing from the symbols mapping written by PerfBasicLogger.
[1] https://crrev.com/9df23510eaa12eb5c298cf68a92e90c6e992855c
BUG=v8:4899
LOG=N
Committed: https://crrev.com/91769d646498bd3d78030c0a49fe203b9fc8cf0a
Cr-Commit-Position: refs/heads/master@{#37224}
Patch Set 1 #
Messages
Total messages: 23 (14 generated)
The CQ bit was checked by ssanfilippo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085143003/1
Description was changed from ========== [Interpreter] Fix missing bytecode handler entries in the perf mapping. The CL that introduced the CodeEventsListener [1] left behind the code creation events emitted when deserializing bytecode handlers from the snapshot. PerfBasicLogger had been registered with the new JIT code events dispatcher, but the events were sent through the old mechanism, and never received. This caused the respective entries to be missing from the perf mapping that is written when FLAG_perf_simple_prof is enabled. [1] https://crrev.com/9df23510eaa12eb5c298cf68a92e90c6e992855c. BUG=v8:4899 LOG=N ========== to ========== [Interpreter] Fix missing bytecode handler entries in the perf mapping. The CL that introduced the CodeEventsListener [1] left behind the code creation events emitted when deserializing bytecode handlers from the snapshot. PerfBasicLogger had been registered with the new JIT code events dispatcher, but the events were sent through the old mechanism, and never received. This caused the respective entries to be missing from the perf mapping that is written when FLAG_perf_simple_prof is enabled. [1] https://crrev.com/9df23510eaa12eb5c298cf68a92e90c6e992855c BUG=v8:4899 LOG=N ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [Interpreter] Fix missing bytecode handler entries in the perf mapping. The CL that introduced the CodeEventsListener [1] left behind the code creation events emitted when deserializing bytecode handlers from the snapshot. PerfBasicLogger had been registered with the new JIT code events dispatcher, but the events were sent through the old mechanism, and never received. This caused the respective entries to be missing from the perf mapping that is written when FLAG_perf_simple_prof is enabled. [1] https://crrev.com/9df23510eaa12eb5c298cf68a92e90c6e992855c BUG=v8:4899 LOG=N ========== to ========== [Interpreter] Fix missing bytecode handler entries in the perf mapping. The CL that introduced the CodeEventsListener [1] left behind the code creation events emitted when deserializing bytecode handlers from the snapshot. PerfBasicLogger had been registered with the new JIT code events dispatcher, but the events were sent through the old mechanism, and ignored. This caused the respective entries to be missing from the perf mapping that is written when FLAG_perf_simple_prof is enabled. [1] https://crrev.com/9df23510eaa12eb5c298cf68a92e90c6e992855c BUG=v8:4899 LOG=N ==========
Description was changed from ========== [Interpreter] Fix missing bytecode handler entries in the perf mapping. The CL that introduced the CodeEventsListener [1] left behind the code creation events emitted when deserializing bytecode handlers from the snapshot. PerfBasicLogger had been registered with the new JIT code events dispatcher, but the events were sent through the old mechanism, and ignored. This caused the respective entries to be missing from the perf mapping that is written when FLAG_perf_simple_prof is enabled. [1] https://crrev.com/9df23510eaa12eb5c298cf68a92e90c6e992855c BUG=v8:4899 LOG=N ========== to ========== [Interpreter] Fix missing bytecode handler entries in the perf mapping. The CL that introduced the CodeEventsListener [1] left behind the code creation events emitted when deserializing bytecode handlers from the snapshot. PerfBasicLogger had been registered with the new JIT code events dispatcher, but the events were sent through the old mechanism, and ignored. This caused the respective entries to be missing from the perf symbols mapping written when FLAG_perf_simple_prof is enabled. [1] https://crrev.com/9df23510eaa12eb5c298cf68a92e90c6e992855c BUG=v8:4899 LOG=N ==========
Description was changed from ========== [Interpreter] Fix missing bytecode handler entries in the perf mapping. The CL that introduced the CodeEventsListener [1] left behind the code creation events emitted when deserializing bytecode handlers from the snapshot. PerfBasicLogger had been registered with the new JIT code events dispatcher, but the events were sent through the old mechanism, and ignored. This caused the respective entries to be missing from the perf symbols mapping written when FLAG_perf_simple_prof is enabled. [1] https://crrev.com/9df23510eaa12eb5c298cf68a92e90c6e992855c BUG=v8:4899 LOG=N ========== to ========== [Interpreter] Fix missing bytecode handler entries in perf symbol mapping. The CL that introduced the CodeEventsListener [1] left behind the code creation events emitted when deserializing bytecode handlers from the snapshot. PerfBasicLogger had been registered with the new JIT code events dispatcher, but the events were sent through the old mechanism, and ignored. This caused the respective entries to be missing from the perf symbols mapping written when FLAG_perf_simple_prof is enabled. [1] https://crrev.com/9df23510eaa12eb5c298cf68a92e90c6e992855c BUG=v8:4899 LOG=N ==========
Description was changed from ========== [Interpreter] Fix missing bytecode handler entries in perf symbol mapping. The CL that introduced the CodeEventsListener [1] left behind the code creation events emitted when deserializing bytecode handlers from the snapshot. PerfBasicLogger had been registered with the new JIT code events dispatcher, but the events were sent through the old mechanism, and ignored. This caused the respective entries to be missing from the perf symbols mapping written when FLAG_perf_simple_prof is enabled. [1] https://crrev.com/9df23510eaa12eb5c298cf68a92e90c6e992855c BUG=v8:4899 LOG=N ========== to ========== [Interpreter] Fix missing bytecode handler entries in perf symbols mapping. The CL that introduced the CodeEventsListener [1] left behind the code creation events emitted when deserializing bytecode handlers from the snapshot. PerfBasicLogger had been registered with the new JIT code events dispatcher, but the events were sent through the old mechanism, and ignored. This caused the respective entries to be missing from the perf symbols mapping written when FLAG_perf_simple_prof is enabled. [1] https://crrev.com/9df23510eaa12eb5c298cf68a92e90c6e992855c BUG=v8:4899 LOG=N ==========
Description was changed from ========== [Interpreter] Fix missing bytecode handler entries in perf symbols mapping. The CL that introduced the CodeEventsListener [1] left behind the code creation events emitted when deserializing bytecode handlers from the snapshot. PerfBasicLogger had been registered with the new JIT code events dispatcher, but the events were sent through the old mechanism, and ignored. This caused the respective entries to be missing from the perf symbols mapping written when FLAG_perf_simple_prof is enabled. [1] https://crrev.com/9df23510eaa12eb5c298cf68a92e90c6e992855c BUG=v8:4899 LOG=N ========== to ========== [Interpreter] Fix missing bytecode handler entries in perf symbols mapping. Since [1], Logger does not dispatch anymore to the other loggers. This is now the task of the CodeEventDispatcher, and Logger is just a client. One use of the Logger as dispatcher wasn't caught in the refactoring, which caused entries for bytecode handlers loaded from the snapshot to be missing from the symbols mapping written by PerfBasicLogger. [1] https://crrev.com/9df23510eaa12eb5c298cf68a92e90c6e992855c BUG=v8:4899 LOG=N ==========
ssanfilippo@chromium.org changed reviewers: + alph@chromium.org, rmcilroy@chromium.org
rmcilroy@ PTAL, thanks. Additionally, alph@ could you please have a look at the fix and the explanation?
Description was changed from ========== [Interpreter] Fix missing bytecode handler entries in perf symbols mapping. Since [1], Logger does not dispatch anymore to the other loggers. This is now the task of the CodeEventDispatcher, and Logger is just a client. One use of the Logger as dispatcher wasn't caught in the refactoring, which caused entries for bytecode handlers loaded from the snapshot to be missing from the symbols mapping written by PerfBasicLogger. [1] https://crrev.com/9df23510eaa12eb5c298cf68a92e90c6e992855c BUG=v8:4899 LOG=N ========== to ========== [Interpreter] Fix missing bytecode handler entries in perf symbols mapping. Since [1], Logger does not dispatch anymore to the other loggers. This is now the task of the CodeEventDispatcher, and Logger is just a client. One use of the Logger as dispatcher wasn't caught in the refactoring, which caused the entries for bytecode handlers loaded from the snapshot to be missing from the symbols mapping written by PerfBasicLogger. [1] https://crrev.com/9df23510eaa12eb5c298cf68a92e90c6e992855c BUG=v8:4899 LOG=N ==========
lgtm
On 2016/06/23 12:40:54, rmcilroy wrote: > lgtm Thank you. I'll wait until this evening before committing to see if alph@ has anything to say.
On 2016/06/23 12:44:33, Stefano Sanfilippo wrote: > On 2016/06/23 12:40:54, rmcilroy wrote: > > lgtm > > Thank you. I'll wait until this evening before committing to see if alph@ has > anything to say. Thanks for the catch! lgtm
Description was changed from ========== [Interpreter] Fix missing bytecode handler entries in perf symbols mapping. Since [1], Logger does not dispatch anymore to the other loggers. This is now the task of the CodeEventDispatcher, and Logger is just a client. One use of the Logger as dispatcher wasn't caught in the refactoring, which caused the entries for bytecode handlers loaded from the snapshot to be missing from the symbols mapping written by PerfBasicLogger. [1] https://crrev.com/9df23510eaa12eb5c298cf68a92e90c6e992855c BUG=v8:4899 LOG=N ========== to ========== [Interpreter] Fix missing entries for bytecode handlers in perf mapping. Since [1], Logger does not dispatch anymore to the other loggers. This is now the task of the CodeEventDispatcher, and Logger is just a client. One use of the Logger as dispatcher wasn't caught in the refactoring, which caused the entries for bytecode handlers loaded from the snapshot to be missing from the symbols mapping written by PerfBasicLogger. [1] https://crrev.com/9df23510eaa12eb5c298cf68a92e90c6e992855c BUG=v8:4899 LOG=N ==========
The CQ bit was checked by ssanfilippo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085143003/1
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Fix missing entries for bytecode handlers in perf mapping. Since [1], Logger does not dispatch anymore to the other loggers. This is now the task of the CodeEventDispatcher, and Logger is just a client. One use of the Logger as dispatcher wasn't caught in the refactoring, which caused the entries for bytecode handlers loaded from the snapshot to be missing from the symbols mapping written by PerfBasicLogger. [1] https://crrev.com/9df23510eaa12eb5c298cf68a92e90c6e992855c BUG=v8:4899 LOG=N ========== to ========== [Interpreter] Fix missing entries for bytecode handlers in perf mapping. Since [1], Logger does not dispatch anymore to the other loggers. This is now the task of the CodeEventDispatcher, and Logger is just a client. One use of the Logger as dispatcher wasn't caught in the refactoring, which caused the entries for bytecode handlers loaded from the snapshot to be missing from the symbols mapping written by PerfBasicLogger. [1] https://crrev.com/9df23510eaa12eb5c298cf68a92e90c6e992855c BUG=v8:4899 LOG=N ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Fix missing entries for bytecode handlers in perf mapping. Since [1], Logger does not dispatch anymore to the other loggers. This is now the task of the CodeEventDispatcher, and Logger is just a client. One use of the Logger as dispatcher wasn't caught in the refactoring, which caused the entries for bytecode handlers loaded from the snapshot to be missing from the symbols mapping written by PerfBasicLogger. [1] https://crrev.com/9df23510eaa12eb5c298cf68a92e90c6e992855c BUG=v8:4899 LOG=N ========== to ========== [Interpreter] Fix missing entries for bytecode handlers in perf mapping. Since [1], Logger does not dispatch anymore to the other loggers. This is now the task of the CodeEventDispatcher, and Logger is just a client. One use of the Logger as dispatcher wasn't caught in the refactoring, which caused the entries for bytecode handlers loaded from the snapshot to be missing from the symbols mapping written by PerfBasicLogger. [1] https://crrev.com/9df23510eaa12eb5c298cf68a92e90c6e992855c BUG=v8:4899 LOG=N Committed: https://crrev.com/91769d646498bd3d78030c0a49fe203b9fc8cf0a Cr-Commit-Position: refs/heads/master@{#37224} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/91769d646498bd3d78030c0a49fe203b9fc8cf0a Cr-Commit-Position: refs/heads/master@{#37224} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
