Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2085133005: Merge M52: "Don't resume paused media. Don't resume playing media after timeout." (Closed)

Created:
4 years, 5 months ago by DaleCurtis
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Merge M52: "Don't resume paused media. Don't resume playing media after timeout." As titled. We shouldn't resume paused media because there's no reason to not wait for the user interaction. We shouldn't resume playing media if the user has moved on to other tasks and comes back some time later. The idle timeout for resuming playing media is 5 seconds as chosen by a dice roll. BUG=617815 TEST=media suspends and resumes as expected. Review-Url: https://codereview.chromium.org/2039793005 Cr-Commit-Position: refs/heads/master@{#399287} (cherry picked from commit 8b8505e78452b365b861025d7b3364ca4b1e5849) Committed: https://chromium.googlesource.com/chromium/src/+/772333224fa164579e5b82770c6dd2e6231f2256

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -10 lines) Patch
M media/blink/webmediaplayer_impl.h View 4 chunks +10 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 7 chunks +38 lines, -5 lines 0 comments Download
M media/blink/webmediaplayer_impl_unittest.cc View 4 chunks +71 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
DaleCurtis
4 years, 5 months ago (2016-06-23 00:21:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
772333224fa164579e5b82770c6dd2e6231f2256.

Powered by Google App Engine
This is Rietveld 408576698