Only process checked state changed for specific roles.

Only process checked state changed for specific roles.

Drive's main doc list fires a checked state changed, which causes us to repeat the same listbox option item read on focus.

BUG=619165
TEST=manual; on drive.google.com
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e5bd187647e715b5aca8755c6f04858d79bcbbcf
Cr-Commit-Position: refs/heads/master@{#402875}

[David Tseng, 2016-06-21 21:22:56]

Description was changed from

==========
Only process checked state changed for specific roles.
==========

to

==========
Only process checked state changed for specific roles.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-06-21 21:24:25]

Description was changed from

==========
Only process checked state changed for specific roles.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Only process checked state changed for specific roles.

Drive's main doc list fires a checked state changed, which causes us to repeat
the same listbox option item read on focus.

BUG=619165
TEST=manual; on drive.google.com
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-06-21 21:24:25]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2016-06-22 05:20:01]

lgtm

https://codereview.chromium.org/2085103002/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
(right):

https://codereview.chromium.org/2085103002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js:211:
this.onEventDefault(
Should this maybe be onEventIfInRange?

I don't think you want it announcing check boxes changing when they're not
focused, most of the time.

[David Tseng, 2016-06-28 19:36:55]

https://codereview.chromium.org/2085103002/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
(right):

https://codereview.chromium.org/2085103002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js:211:
this.onEventDefault(
On 2016/06/22 05:20:01, dmazzoni wrote:
> Should this maybe be onEventIfInRange?
> 
> I don't think you want it announcing check boxes changing when they're not
> focused, most of the time.

Done.

[David Tseng, 2016-06-28 19:37:31]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-06-28 19:37:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2085103002/#ps20001
(title: "Fix formatting; use onEventIfInRange")

[commit-bot: I haz the power, 2016-06-28 19:39:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 19:45:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 19:45:43]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[David Tseng, 2016-06-29 17:37:07]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2016-06-29 17:38:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 18:29:36]

Description was changed from

==========
Only process checked state changed for specific roles.

Drive's main doc list fires a checked state changed, which causes us to repeat
the same listbox option item read on focus.

BUG=619165
TEST=manual; on drive.google.com
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Only process checked state changed for specific roles.

Drive's main doc list fires a checked state changed, which causes us to repeat
the same listbox option item read on focus.

BUG=619165
TEST=manual; on drive.google.com
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-06-29 18:29:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-29 18:29:59]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-29 18:31:53]

Description was changed from

==========
Only process checked state changed for specific roles.

Drive's main doc list fires a checked state changed, which causes us to repeat
the same listbox option item read on focus.

BUG=619165
TEST=manual; on drive.google.com
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Only process checked state changed for specific roles.

Drive's main doc list fires a checked state changed, which causes us to repeat
the same listbox option item read on focus.

BUG=619165
TEST=manual; on drive.google.com
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e5bd187647e715b5aca8755c6f04858d79bcbbcf
Cr-Commit-Position: refs/heads/master@{#402875}
==========

[commit-bot: I haz the power, 2016-06-29 18:31:55]

Patchset 2 (id:??) landed as
https://crrev.com/e5bd187647e715b5aca8755c6f04858d79bcbbcf
Cr-Commit-Position: refs/heads/master@{#402875}