Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2085043004: [builtins] Fix clobbered reg in Math.{Max,Min} (Closed)

Created:
4 years, 6 months ago by jgruber
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Fix clobbered reg in Math.{Max,Min} edi is expected to contain the JS function. Ensure that it is not overwritten. BUG=chromium:621431, chromium:621550, chromium:621217 R=bmeurer@chromium.org Committed: https://crrev.com/6bd37e3f20651cc4ff780e09518ae2a408b509dc Cr-Commit-Position: refs/heads/master@{#37173}

Patch Set 1 #

Patch Set 2 : Push/Pop #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/ia32/builtins-ia32.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
jgruber
4 years, 6 months ago (2016-06-22 07:07:51 UTC) #1
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-06-22 07:51:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085043004/1
4 years, 6 months ago (2016-06-22 07:51:48 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_nosnap_shared_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng/builds/3683) v8_win_nosnap_shared_rel_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 6 months ago (2016-06-22 08:08:52 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085043004/20001
4 years, 6 months ago (2016-06-22 08:45:59 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-22 09:15:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085043004/20001
4 years, 6 months ago (2016-06-22 09:16:31 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-22 09:18:36 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 09:19:04 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6bd37e3f20651cc4ff780e09518ae2a408b509dc
Cr-Commit-Position: refs/heads/master@{#37173}

Powered by Google App Engine
This is Rietveld 408576698