Issue 208503006: Revert of DevTools: Implement Styles search and Computed style filter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 208503006: Revert of DevTools: Implement Styles search and Computed style filter (Closed)

Created:
6 years, 9 months ago by apavlov

Modified:
6 years, 9 months ago

Reviewers:
eustas, vsevik, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Revert of DevTools: Implement Styles search and Computed style filter (https://codereview.chromium.org/129793013/) Reason for revert: Broke the Styles pane Original issue's description: > DevTools: Implement Styles search and Computed style filter > > The user can search styles by property name, value, or rule selector. > Computed style properties are filtered, so that only matching ones are visible. > > R=eustas, pfeldman, vsevik > BUG=278852 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169860 TBR=eustas@chromium.org,pfeldman@chromium.org,vsevik@chromium.org NOTREECHECKS=true NOTRY=true BUG=278852 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169931

Patch Set 1 #

Created: 6 years, 9 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -313 lines)			Patch
M	Source/devtools/front_end/ElementsPanel.js	View	7 chunks	+19 lines, -42 lines	0 comments	Download
M	Source/devtools/front_end/Settings.js	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/devtools/front_end/StylesSidebarPane.js	View	17 chunks	+13 lines, -230 lines	0 comments	Download
M	Source/devtools/front_end/elementsPanel.css	View	5 chunks	+9 lines, -39 lines	0 comments	Download
M	Source/devtools/front_end/sidebarPane.css	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/devtools/front_end/utilities.js	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

apavlov

Created Revert of DevTools: Implement Styles search and Computed style filter

6 years, 9 months ago (2014-03-25 11:32:31 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/208503006/1

6 years, 9 months ago (2014-03-25 11:32:33 UTC) #2

Message was sent while issue was closed.

Change committed as 169931

Expand Messages | Collapse Messages