Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 208503002: Reduce rootElement access boilerplate in SVGImage (Closed)

Created:
6 years, 9 months ago by fs
Modified:
6 years, 9 months ago
CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, rwlbuis
Visibility:
Public.

Description

Reduce rootElement access boilerplate in SVGImage Add a helper function 'svgRootElement' and use that where appropriate. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169751

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -40 lines) Patch
M Source/core/svg/graphics/SVGImage.cpp View 10 chunks +20 lines, -40 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
fs
6 years, 9 months ago (2014-03-21 17:17:24 UTC) #1
pdr.
On 2014/03/21 17:17:24, fs wrote: LGTM
6 years, 9 months ago (2014-03-21 17:27:25 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-21 17:35:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/208503002/1
6 years, 9 months ago (2014-03-21 17:35:30 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-21 17:49:32 UTC) #5
Message was sent while issue was closed.
Change committed as 169751

Powered by Google App Engine
This is Rietveld 408576698