Remove calls to deprecated MessageLoop methods in tools.

Remove calls to deprecated MessageLoop methods in tools.

This CL makes the following replacements in
tools:

Before               After
----------------------------------------------------------
 x.PostTask()          x.task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()
x->PostTask()         y->task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

 x.Run()              RunLoop().Run()
 x.RunUntilIdle()     RunLoop().RunUntilIdle()

x->Run()              RunLoop().Run()
x->RunUntilIdle()     RunLoop().RunUntilIdle()
    If |y| isn't MessageLoopForUI::current() or
    MessageLoopForIO::current()

 y.message_loop()->task_runner()
                      y.task_runner()
y->message_loop()->task_runner()
                      y->task_runner()
----------------------------------------------------------

|x| is a base::MessageLoop(ForUI|ForIO) or a pointer to
a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread
or a pointer to a base::Thread.

This CL was generated using the MessageLoopDeprecatedMethods
clang-tidy fix available on the associated bug. Only files
that compile on Mac are affected. Follow-up CLs will make
these replacements for other platforms.

This CL doesn't change code behavior.

BUG=616447
R=thakis@chromium.org

Committed: https://crrev.com/01c8157ece1ba00df660bdf8c17cf01bae3cd230
Cr-Commit-Position: refs/heads/master@{#401371}

[fdoray, 2016-06-22 15:44:34]

Can you review this CL? Thanks.

[Nico, 2016-06-22 18:22:28]

rs-lgtm

https://codereview.chromium.org/2085023004/diff/1/tools/gn/loader_unittest.cc
File tools/gn/loader_unittest.cc (right):

https://codereview.chromium.org/2085023004/diff/1/tools/gn/loader_unittest.cc...
tools/gn/loader_unittest.cc:150: base::RunLoop().RunUntilIdle();
(this replacement looks like it makes things more singleton-y and seems like a
step back to me)

[fdoray, 2016-06-22 18:41:51]

https://codereview.chromium.org/2085023004/diff/1/tools/gn/loader_unittest.cc
File tools/gn/loader_unittest.cc (right):

https://codereview.chromium.org/2085023004/diff/1/tools/gn/loader_unittest.cc...
tools/gn/loader_unittest.cc:150: base::RunLoop().RunUntilIdle();
On 2016/06/22 18:22:28, Nico wrote:
> (this replacement looks like it makes things more singleton-y and seems like a
> step back to me)

Ironically, a goal of base::RunLoop is to make things less singleton-y.

Currently, the last call to MessageLoop::Run on the thread can be exited by
calling MessageLoop::current()->QuitNow/QuitWhenIdle.

On the other hand, to call RunLoop::Quit/QuitWhenIdle, you need a pointer to a
RunLoop (i.e. you must know which RunLoop you exit and the owned of the RunLoop
must have allowed you to do that).

Using RunLoop makes code more base/task_scheduler friendly (doesn't assume that
it is running on a MessageLoop). Maybe having a base::RunLoop constructor that
takes a MessageLoop as argument (and DCHECK_EQ(base::MessageLoop::current,
message_loop) would make things less singleton-y?

Note that scheduler_.main_loop()->RunUntilIdle(); is extremely misleading! It
runs the current thread's MessageLoop, not necessarily scheduler_.main_loop()
(see
https://cs.chromium.org/chromium/src/base/message_loop/message_loop.cc?sq=pac...)

[fdoray, 2016-06-22 18:42:33]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-06-22 18:43:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2085023004/1

[commit-bot: I haz the power, 2016-06-22 18:49:31]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-22 18:58:02]

Description was changed from

==========
Remove calls to deprecated MessageLoop methods in tools.

This CL makes the following replacements in
tools:

Before               After
----------------------------------------------------------
 x.PostTask()          x.task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()
x->PostTask()         y->task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

 x.Run()              RunLoop().Run()
 x.RunUntilIdle()     RunLoop().RunUntilIdle()

x->Run()              RunLoop().Run()
x->RunUntilIdle()     RunLoop().RunUntilIdle()
    If |y| isn't MessageLoopForUI::current() or
    MessageLoopForIO::current()

 y.message_loop()->task_runner()
                      y.task_runner()
y->message_loop()->task_runner()
                      y->task_runner()
----------------------------------------------------------

|x| is a base::MessageLoop(ForUI|ForIO) or a pointer to
a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread
or a pointer to a base::Thread.

This CL was generated using the MessageLoopDeprecatedMethods
clang-tidy fix available on the associated bug. Only files
that compile on Mac are affected. Follow-up CLs will make
these replacements for other platforms.

This CL doesn't change code behavior.

BUG=616447
R=thakis@chromium.org
==========

to

==========
Remove calls to deprecated MessageLoop methods in tools.

This CL makes the following replacements in
tools:

Before               After
----------------------------------------------------------
 x.PostTask()          x.task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()
x->PostTask()         y->task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

 x.Run()              RunLoop().Run()
 x.RunUntilIdle()     RunLoop().RunUntilIdle()

x->Run()              RunLoop().Run()
x->RunUntilIdle()     RunLoop().RunUntilIdle()
    If |y| isn't MessageLoopForUI::current() or
    MessageLoopForIO::current()

 y.message_loop()->task_runner()
                      y.task_runner()
y->message_loop()->task_runner()
                      y->task_runner()
----------------------------------------------------------

|x| is a base::MessageLoop(ForUI|ForIO) or a pointer to
a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread
or a pointer to a base::Thread.

This CL was generated using the MessageLoopDeprecatedMethods
clang-tidy fix available on the associated bug. Only files
that compile on Mac are affected. Follow-up CLs will make
these replacements for other platforms.

This CL doesn't change code behavior.

BUG=616447
R=thakis@chromium.org

Committed: https://crrev.com/01c8157ece1ba00df660bdf8c17cf01bae3cd230
Cr-Commit-Position: refs/heads/master@{#401371}
==========

[commit-bot: I haz the power, 2016-06-22 18:58:03]

Patchset 1 (id:??) landed as
https://crrev.com/01c8157ece1ba00df660bdf8c17cf01bae3cd230
Cr-Commit-Position: refs/heads/master@{#401371}