Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2085023002: Cherry-pick 875e13ca0 to M52. (Closed)

Created:
4 years, 6 months ago by mtklein_C
Modified:
4 years, 6 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@m52
Target Ref:
refs/heads/chrome/m52
Project:
skia
Visibility:
Public.

Description

Cherry-pick 875e13ca0 to M52. TBR= Original description: Simplify mask/clip intersection, making sure to explicitly check for an empty mask. Previously we were only asserting the mask wasn't empty, which isn't necessarily true when we're given pathological float coordinates like +Inf or NaN. A local run of nanobench --match text_ was not able to show this is faster or slower. This patch fixed this first Chrome bug on my desktop, and the second is probably a dupe. BUG=chromium:619378, chromium:613912 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2073873002 Review-Url: https://codereview.chromium.org/2073873002 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=2085023002 NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true Committed: https://skia.googlesource.com/skia/+/c20d6706cc0220956c43a020a1a71c4e73a468e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -4 lines) Patch
M src/core/SkDraw.cpp View 2 chunks +8 lines, -4 lines 0 comments Download
M tests/DrawTextTest.cpp View 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085023002/1
4 years, 6 months ago (2016-06-21 19:03:32 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 19:03:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c20d6706cc0220956c43a020a1a71c4e73a468e0

Powered by Google App Engine
This is Rietveld 408576698