Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Issue 2085013002: Add warning for non-https remotes in Gerrit git cl upload. (Closed)

Created:
4 years, 6 months ago by tandrii(chromium)
Modified:
4 years, 6 months ago
CC:
chromium-reviews, tandrii+omg_git_cl_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M git_cl.py View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
tandrii(chromium)
4 years, 6 months ago (2016-06-21 18:24:28 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085013002/1
4 years, 6 months ago (2016-06-21 18:24:39 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-21 18:27:48 UTC) #5
shinyak (Google)
lgtm Thanks for the fix!
4 years, 6 months ago (2016-06-22 02:10:08 UTC) #7
shinyak
re-lgtm with chromium account ><
4 years, 6 months ago (2016-06-22 02:11:46 UTC) #8
Sergiy Byelozyorov
lgtm
4 years, 6 months ago (2016-06-22 04:05:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085013002/1
4 years, 6 months ago (2016-06-22 09:49:36 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 09:52:53 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/e32e3eaebdd32d...

Powered by Google App Engine
This is Rietveld 408576698