media/filters/ffmpeg_demuxer_unittest.cc - Issue 2085012: Reporting a more accurate buffered time for the video tag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/ffmpeg_demuxer_unittest.cc

Issue 2085012: Reporting a more accurate buffered time for the video tag (Closed)

Patch Set: Added checks to fix some edgecase bugs. Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/filters/ffmpeg_demuxer_unittest.cc

diff --git a/media/filters/ffmpeg_demuxer_unittest.cc b/media/filters/ffmpeg_demuxer_unittest.cc

index 31d575f0dc4e8afbb22e585c8dfe08f10ebadcb4..ec263a6ee2db7662e331360631f0ecf20b84b773 100644

--- a/media/filters/ffmpeg_demuxer_unittest.cc

+++ b/media/filters/ffmpeg_demuxer_unittest.cc

@@ -716,6 +716,7 @@ TEST_F(FFmpegDemuxerTest, ProtocolRead) {

EXPECT_CALL(*demuxer, SignalReadCompleted(512));

EXPECT_CALL(*demuxer, WaitForRead())

.WillOnce(Return(512));

+ EXPECT_CALL(host_, SetCurrentReadPosition(512));

// Second read.

EXPECT_CALL(*data_source_, GetSize(_))

@@ -725,6 +726,7 @@ TEST_F(FFmpegDemuxerTest, ProtocolRead) {

EXPECT_CALL(*demuxer, SignalReadCompleted(512));

EXPECT_CALL(*demuxer, WaitForRead())

.WillOnce(Return(512));

+ EXPECT_CALL(host_, SetCurrentReadPosition(1024));

// Third read will fail because it exceeds the file size.

EXPECT_CALL(*data_source_, GetSize(_))

« no previous file with comments | « media/filters/ffmpeg_demuxer.cc ('k') | webkit/glue/webmediaplayer_impl.h » ('j') | no next file with comments »