Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: webkit/glue/webmediaplayer_impl.h

Issue 2085012: Reporting a more accurate buffered time for the video tag (Closed)
Patch Set: Added checks to fix some edgecase bugs. Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/filters/ffmpeg_demuxer_unittest.cc ('k') | webkit/glue/webmediaplayer_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Delegate calls from WebCore::MediaPlayerPrivate to Chrome's video player. 5 // Delegate calls from WebCore::MediaPlayerPrivate to Chrome's video player.
6 // It contains PipelineImpl which is the actual media player pipeline, it glues 6 // It contains PipelineImpl which is the actual media player pipeline, it glues
7 // the media player pipeline, data source, audio renderer and renderer. 7 // the media player pipeline, data source, audio renderer and renderer.
8 // PipelineImpl would creates multiple threads and access some public methods 8 // PipelineImpl would creates multiple threads and access some public methods
9 // of this class, so we need to be extra careful about concurrent access of 9 // of this class, so we need to be extra careful about concurrent access of
10 // methods and members. 10 // methods and members.
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 virtual void pause(); 181 virtual void pause();
182 virtual bool supportsFullscreen() const; 182 virtual bool supportsFullscreen() const;
183 virtual bool supportsSave() const; 183 virtual bool supportsSave() const;
184 virtual void seek(float seconds); 184 virtual void seek(float seconds);
185 virtual void setEndTime(float seconds); 185 virtual void setEndTime(float seconds);
186 virtual void setRate(float rate); 186 virtual void setRate(float rate);
187 virtual void setVolume(float volume); 187 virtual void setVolume(float volume);
188 virtual void setVisible(bool visible); 188 virtual void setVisible(bool visible);
189 virtual bool setAutoBuffer(bool autoBuffer); 189 virtual bool setAutoBuffer(bool autoBuffer);
190 virtual bool totalBytesKnown(); 190 virtual bool totalBytesKnown();
191 virtual const WebKit::WebTimeRanges& buffered();
191 virtual const WebKit::WebTimeRanges& buffered() const; 192 virtual const WebKit::WebTimeRanges& buffered() const;
192 virtual float maxTimeSeekable() const; 193 virtual float maxTimeSeekable() const;
193 194
194 // Methods for painting. 195 // Methods for painting.
195 virtual void setSize(const WebKit::WebSize& size); 196 virtual void setSize(const WebKit::WebSize& size);
196 197
197 virtual void paint(WebKit::WebCanvas* canvas, const WebKit::WebRect& rect); 198 virtual void paint(WebKit::WebCanvas* canvas, const WebKit::WebRect& rect);
198 199
199 // True if the loaded media has a playable video/audio track. 200 // True if the loaded media has a playable video/audio track.
200 virtual bool hasVideo() const; 201 virtual bool hasVideo() const;
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
322 WebMediaPlayerImpl::Proxy* proxy) = 0; 323 WebMediaPlayerImpl::Proxy* proxy) = 0;
323 324
324 private: 325 private:
325 DISALLOW_COPY_AND_ASSIGN(WebVideoRendererFactoryFactory); 326 DISALLOW_COPY_AND_ASSIGN(WebVideoRendererFactoryFactory);
326 }; 327 };
327 328
328 329
329 } // namespace webkit_glue 330 } // namespace webkit_glue
330 331
331 #endif // WEBKIT_GLUE_WEBMEDIAPLAYER_IMPL_H_ 332 #endif // WEBKIT_GLUE_WEBMEDIAPLAYER_IMPL_H_
OLDNEW
« no previous file with comments | « media/filters/ffmpeg_demuxer_unittest.cc ('k') | webkit/glue/webmediaplayer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698