Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2085003002: Parse field initializer expressions in the correct scope class (Closed)

Created:
4 years, 6 months ago by hausner
Modified:
4 years, 6 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Parse field initializer expressions in the correct scope class When parsing a field initializer expression or mixin fields, the current_class must be the mixin application class, not the mixin class. This is necessary so that type arguments are resolved in the correct scope class. Dart2js fails the new regression test language/regress_18713. Filed issue #26743. BUG=18713 R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/26593c7688d1618eb17651f6a554dda62fc9afd0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -7 lines) Patch
M runtime/vm/parser.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +2 lines, -0 lines 0 comments Download
A tests/language/regress_18713_test.dart View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
hausner
4 years, 6 months ago (2016-06-21 18:23:44 UTC) #3
regis
LGTM
4 years, 6 months ago (2016-06-21 18:31:49 UTC) #4
hausner
4 years, 6 months ago (2016-06-21 19:32:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
26593c7688d1618eb17651f6a554dda62fc9afd0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698