Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 2084973002: [Docs] Add native heap profiling instructions. (Closed)

Created:
4 years, 6 months ago by Dmitry Skiba
Modified:
4 years, 5 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Docs] Add native heap profiling instructions. Native heap profiling captures C/C++ backtraces for allocations, but requires a special build (and a symbolization step). BUG=602701 Committed: https://crrev.com/2914afa182f14140fb21bc9a68e058452474a0e3 Cr-Commit-Position: refs/heads/master@{#403269}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
M components/tracing/docs/heap_profiler.md View 1 chunk +54 lines, -0 lines 2 comments Download

Messages

Total messages: 11 (5 generated)
Dmitry Skiba
4 years, 6 months ago (2016-06-21 15:51:03 UTC) #1
Primiano Tucci (use gerrit)
LGTM, sorry forgot about this CL https://codereview.chromium.org/2084973002/diff/1/components/tracing/docs/heap_profiler.md File components/tracing/docs/heap_profiler.md (right): https://codereview.chromium.org/2084973002/diff/1/components/tracing/docs/heap_profiler.md#newcode48 components/tracing/docs/heap_profiler.md:48: enable_profiling = true ...
4 years, 5 months ago (2016-06-30 14:45:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2084973002/1
4 years, 5 months ago (2016-06-30 19:34:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 20:28:11 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 20:28:13 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 20:31:20 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2914afa182f14140fb21bc9a68e058452474a0e3
Cr-Commit-Position: refs/heads/master@{#403269}

Powered by Google App Engine
This is Rietveld 408576698