Fix clicks on NTP tiles not contributing to Most Visited tiles

chrome/browser/chrome_content_browser_client.cc

Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index cce6055d14114802396ae3cbd025d6e14eba2cb0..c8c43652acb259c92ccaa179f9e25eaa0d5b8db8 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -1154,6 +1154,26 @@ bool ChromeContentBrowserClient::ShouldAllowOpenURL(
   return true;
 }
 
+void ChromeContentBrowserClient::OverrideOpenURLParams(
+    content::SiteInstance* site_instance,
+    content::OpenURLParams* params) {
+  DCHECK(params);
+  if (site_instance &&
+      site_instance->GetSiteURL().SchemeIs(chrome::kChromeSearchScheme) &&
+      (site_instance->GetSiteURL().host() ==
+           chrome::kChromeSearchRemoteNtpHost ||
+       site_instance->GetSiteURL().host() ==
+           chrome::kChromeSearchLocalNtpHost) &&

[Charlie Reis, 2016/06/28 17:57:35]

Sanity check: The NTP SiteInstance's Site URL is never https://google.com (e.g.,
when we load https://www.google.com/_/chrome/newtab), right?  Hopefully it's
kChromeSearchRemoteNtpHost in that case?  

(Not a big deal; that would be a false negative, which is just a functional bug
like the one we're fixing with this CL.  I don't see any opportunities for false
positives here, but let me know if you do-- that would be a security bug where
web pages could do things they aren't allowed to.)

[mastiz, 2016/06/29 14:20:14]

I double-checked and for the case above, it is indeed
kChromeSearchRemoteNtpHost, so it just works.

[Charlie Reis, 2016/06/29 19:27:00]

Thanks for checking.

+      ui::PageTransitionCoreTypeIs(params->transition,
+                                   ui::PAGE_TRANSITION_LINK)) {
+    // Use AUTO_BOOKMARK for clicks on tiles of the new tab page, consistently
+    // with native implementations like Android's.
+    params->transition = ui::PAGE_TRANSITION_AUTO_BOOKMARK;
+    params->is_renderer_initiated = false;
+    params->referrer = content::Referrer();
+  }
+}
+
 bool ChromeContentBrowserClient::IsSuitableHost(
     content::RenderProcessHost* process_host,
     const GURL& site_url) {